Giter VIP home page Giter VIP logo

Comments (8)

joshdholtz avatar joshdholtz commented on May 18, 2024 2

@mrtj I think I had it "highly suggested" because I didn't test it with multiple apps in the same bucket 😬 I can work on adding this feature though - it makes sense and I really don't know why I had it as that in the first place

from fastlane-plugin-s3.

fhickman avatar fhickman commented on May 18, 2024 1

@joshdholtz I've tried it out locally, works like a charm. You've got my vote for merging it into master.

Thanks!

from fastlane-plugin-s3.

fhickman avatar fhickman commented on May 18, 2024

Agreed, it would be very handy to have an app_path configuration variable (which would default to the bucket root), and could be used to organize apps (or branches of apps) under a single S3 bucket.

from fastlane-plugin-s3.

joshdholtz avatar joshdholtz commented on May 18, 2024

@mrtj @fhickman I just created #11 to add this feature. If either of you would like to review/try the PR before I merge that would be greatly appreciated 😊

from fastlane-plugin-s3.

mrtj avatar mrtj commented on May 18, 2024

Wonderful! I would love to try your PR but being very newbie in ruby/ruby package manager I don't know how could I install a temporary version of aws_s3 plugin from your branch?

from fastlane-plugin-s3.

joshdholtz avatar joshdholtz commented on May 18, 2024

@mrtj Try changing your Pluginfile to following and then run bundle install...

gem 'fastlane-plugin-s3', git: 'https://github.com/joshdholtz/fastlane-plugin-s3.git', branch: 'app-directory'

from fastlane-plugin-s3.

n1mda avatar n1mda commented on May 18, 2024

Can you release version 0.2.2 so this is available without pointing the gemfile to a specific branch?

from fastlane-plugin-s3.

joshdholtz avatar joshdholtz commented on May 18, 2024

@n1mda Should be released now!

from fastlane-plugin-s3.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.