First app creation requires adding companyName about spaceship HOT 5 CLOSED

Yes, that would be awesome: fastlane-old/produce#54

Adding an optional parameter to create_application! sounds like a good plan.

Also, while you're at it, could you also raise a nice exception when the company name is required but not provided by the user?

from spaceship.

Maybe @robwithhair and @buscarini have some comments 👍

from spaceship.

could you also raise a nice exception when the company name is required but not provided by the user?

ITC already does that and I have a test for that. See above PR. I find it strange that there's really no test on the part that does the creation work, https://github.com/fastlane/spaceship/blob/a4d7a8ca137b30dba4fae2482a7b40ef5d640b2e/lib/spaceship/tunes/tunes_client.rb#L148-L155

We test parsing data from ITC, but not that we are sending the right data.

Or am I missing something ?

from spaceship.

@lacostej that's right, mostly responses right now.

from spaceship.

This issue was migrated to fastlane/fastlane#2073. Please post all further comments there.

fastlane is now a mono repo, you can read more about the change in our blog post. All tools are now available in the fastlane main repo 🚀

from spaceship.