Line handling of nans about fastplotlib HOT 7 CLOSED

Yes I see, I encountered this issue with the HistogramGraphic previously and fixed it in #28

We could just implement it in the base Graphic when data are converted to float32, do you want to do your first PR? :D https://github.com/kushalkolar/fastplotlib/blob/master/fastplotlib/graphics/_base.py#L19

from fastplotlib.

Seems like a good one for start with for sure :) Might take me a little while to get to it (weekend likely).

from fastplotlib.

thinking about this more, for lines we don't want to show it as zeros though becuase this will actually move the position of the line vertex, maybe we can set the alpha value for the color at those points to zero

from fastplotlib.

Yes the zero strategy won’t work for lines. Either need to interpolate or make the relevant bits disappear. For the latter, could split into multiple lines or the alpha trick sound good. Having to track multiple separate line objects would probably be a pain!

from fastplotlib.

splitting into multiple lines would be a major pain, definitely try the alpha method!

from fastplotlib.

I made a PR in pygfx which should fix this, it was a camera issue because autoscaling isn't possible when the bbox is nan:

pygfx/pygfx#540

from fastplotlib.

fixed in pygfx/pygfx#540

from fastplotlib.