Giter VIP home page Giter VIP logo

Comments (4)

chrigu avatar chrigu commented on July 25, 2024 1

My only wish is that you check on your own that the proxy connection will work. There are no tests in the repository, so that's the only way. Regardless, your implementation looks simple and straightforward. Sorry for the late response, I’m looking forward to the PR!

Thanks for looking at it! I saw some smaller issues that I need to take care of before I'll make a PR. Maybe I'll make another PR with some tests, but then you decide if you wanted to introduce pytest in the library for testing.

from aioapns.

LunNova avatar LunNova commented on July 25, 2024

This is surprisingly hard to do with h2, which this project uses.

It's easy with httpx.

from aioapns.

chrigu avatar chrigu commented on July 25, 2024

Maybe I’m a bit late to the party, but I’ve made proof of concept for basic HTTP-proxies.

In a nutshell there’s a HttpProxyProtocol (https://github.com/chrigu/aioapns/blob/feature/http-proxy/aioapns/connection.py#L594) that sets up the connection to the proxy and then initiates the connection to the APNs host using the existing APNsClientProtocols.

As mentioned, it’s still work in progress (it needs types, more error handling and some refactoring).
@Fatal1ty Before I start with a PR, could you please have a look and point out any improvements or obvious things that could lead to errors? Thanks!

from aioapns.

Fatal1ty avatar Fatal1ty commented on July 25, 2024

Maybe I’m a bit late to the party, but I’ve made proof of concept for basic HTTP-proxies.

In a nutshell there’s a HttpProxyProtocol (https://github.com/chrigu/aioapns/blob/feature/http-proxy/aioapns/connection.py#L594) that sets up the connection to the proxy and then initiates the connection to the APNs host using the existing APNsClientProtocols.

As mentioned, it’s still work in progress (it needs types, more error handling and some refactoring). @Fatal1ty Before I start with a PR, could you please have a look and point out any improvements or obvious things that could lead to errors? Thanks!

My only wish is that you check on your own that the proxy connection will work. There are no tests in the repository, so that's the only way. Regardless, your implementation looks simple and straightforward. Sorry for the late response, I’m looking forward to the PR!

from aioapns.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.