Comments (4)
My only wish is that you check on your own that the proxy connection will work. There are no tests in the repository, so that's the only way. Regardless, your implementation looks simple and straightforward. Sorry for the late response, I’m looking forward to the PR!
Thanks for looking at it! I saw some smaller issues that I need to take care of before I'll make a PR. Maybe I'll make another PR with some tests, but then you decide if you wanted to introduce pytest in the library for testing.
from aioapns.
This is surprisingly hard to do with h2
, which this project uses.
It's easy with httpx
.
from aioapns.
Maybe I’m a bit late to the party, but I’ve made proof of concept for basic HTTP-proxies.
In a nutshell there’s a HttpProxyProtocol (https://github.com/chrigu/aioapns/blob/feature/http-proxy/aioapns/connection.py#L594) that sets up the connection to the proxy and then initiates the connection to the APNs host using the existing APNsClientProtocols.
As mentioned, it’s still work in progress (it needs types, more error handling and some refactoring).
@Fatal1ty Before I start with a PR, could you please have a look and point out any improvements or obvious things that could lead to errors? Thanks!
from aioapns.
Maybe I’m a bit late to the party, but I’ve made proof of concept for basic HTTP-proxies.
In a nutshell there’s a HttpProxyProtocol (https://github.com/chrigu/aioapns/blob/feature/http-proxy/aioapns/connection.py#L594) that sets up the connection to the proxy and then initiates the connection to the APNs host using the existing APNsClientProtocols.
As mentioned, it’s still work in progress (it needs types, more error handling and some refactoring). @Fatal1ty Before I start with a PR, could you please have a look and point out any improvements or obvious things that could lead to errors? Thanks!
My only wish is that you check on your own that the proxy connection will work. There are no tests in the repository, so that's the only way. Regardless, your implementation looks simple and straightforward. Sorry for the late response, I’m looking forward to the PR!
from aioapns.
Related Issues (20)
- Add marker file for type annotations
- JWT Token re-generated on every notification HOT 4
- What is the key_id? HOT 1
- Could not deserialize key data
- It gives error when used .p8 file instead pem file. What should I have to do??? HOT 2
- response header decoding depends on h2's version, need fix
- Connection Lost makes infinite blocking
- Deadlock following timeout
- Response status is 200. But device is not receiving notification HOT 1
- Get reason and timestamp in error responses for 410 status codes HOT 1
- How to form the certificate HOT 3
- Is there a way to reuse the connection? HOT 5
- Could not send notification - ConnectionClosed HOT 1
- Add support for Python 3.12 HOT 1
- Getting 400 (BadDeviceToken) HOT 3
- Any compatibility with uvloop? HOT 1
- Failing to connect to APNS - MaxAttemptsExceeded HOT 1
- APNsKeyConnectionPool - incorrect use of key_file
- Connections terminate with a reason of `Shutdown` HOT 2
- certificaton error when send push notification
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aioapns.