Provide options to to_dict and from_dict calls. about mashumaro HOT 8 CLOSED

I did a few tests and it looks good.

from mashumaro.

Why don't use hooks? Сan you show an example in which the hooks wouldn't be enough?

from mashumaro.

Theoretically, I could add a flag in the field / datacalss config to specify whether such options should be passed to the hook calls somehow. This flag could be turned off by default just to maintain better performance in most cases when the options aren't needed.

from mashumaro.

The main thing we use this for is a flag to indicate whether the 'to_dict' output would skip attributes that are set to 'None'. I though that an 'options' dictionary would be more flexible in that we could implement other options. Another thing that we need in a couple of places is converting field names to and from names with hyphens and underscores. At the moment either an options dictionary or an 'omit_none' or 'keep_none' flag would handle our requirements.

from mashumaro.

Seems like omit_none flag sounds reasonable. I'll try my best to add it soon.

from mashumaro.

@gshank I'm working on the configuration class that can change the code generation by adding omit_none flag to to_dict method signature. It's not the final version but you can test it: https://github.com/Fatal1ty/mashumaro/tree/config-class

from typing import Optional
from mashumaro import DataClassDictMixin
from mashumaro.config import TO_DICT_ADD_OMIT_NONE_FLAG

class BaseModel(DataClassDictMixin):
    class Config:
        code_generation_options = [
            TO_DICT_ADD_OMIT_NONE_FLAG,
        ]

class Model(BaseModel):
    a: Optional[str] = None

print(Model().to_dict(omit_none=True))  # {}

from mashumaro.

Thanks! I'll take a look. If you're interested I put the code that I was using into https://github.com/gshank/mashumaro/tree/callout_options. Your method might be better though.

from mashumaro.

These changes are in master branch already, so I close this issue.

from mashumaro.