Giter VIP home page Giter VIP logo

Comments (8)

michaeldv avatar michaeldv commented on July 23, 2024

Alex, can you please provide steps to reproduce the issue?

from fat_free_crm.

ajsharp avatar ajsharp commented on July 23, 2024

This seems to happen with any task that has a specific date attached to it. I may try to solve this on my fork of the project. If I do, I'll send you a message and submit a pull request.

from fat_free_crm.

ajsharp avatar ajsharp commented on July 23, 2024

It's looking like this problem only occurs for overdue tasks

from fat_free_crm.

ajsharp avatar ajsharp commented on July 23, 2024

This may have something to do with the :bucket field in the Task model. Could this be an issue with the finder methods used for TasksController#index?

The following params are sent to TasksController#complete when I try to update an overdue task:

{"bucket"=>"overdue", "action"=>"complete", "_method"=>"put", "id"=>"17", "controller"=>"tasks"}

from fat_free_crm.

michaeldv avatar michaeldv commented on July 23, 2024

What are the symptoms? Can you copy/paste errors from the log file? If you could to write a quick spec that fails that would be even better.

from fat_free_crm.

ajsharp avatar ajsharp commented on July 23, 2024

There are no errors, the request submits successfully. I'm thinking it may be a logical error in one of the named scopes? I'm working on a failing spec.

from fat_free_crm.

dpickett avatar dpickett commented on July 23, 2024

+1 on this error - completion does not persist.

from fat_free_crm.

michaeldv avatar michaeldv commented on July 23, 2024

I think the latest tip of the master addresses this issue. What we've discovered was actually two bugs: 1) invalid due date assignment because of missing time zone (Time.zone.now instead of Time.now), and 2) task validation bug that prevented tasks with specific due date from being closed.

Both issues now have tests that pass, so I think we're in a good shape.

from fat_free_crm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.