addMonth() make invalid date in some cases about shamsi_date HOT 5 CLOSED

Hi,
I have fixed the issue in version 0.9.0.

Now ALL created date instances are valid. When you are creating a new date instance if think it can be invalid or become out of computable range you should surround code block with try-catch and capture DateException.

Is your problem solved ?
@NaarGes

from shamsi_date.

I've handled this case manually

Now in the 0.9.0 version you can soround your code block with try-catch instead of handling manually. Sorry for being so late in solving this issue, I didn't have time ...

I'll close this issue. If your problem is not solved feel free to reopen this issue or creating another one ...

@NaarGes

from shamsi_date.

Hi,
This is a known issue, but I don't know how to solve it!

At present my project is to make some changes on the next release to enforce dates being valid. Then if you want to create an invalid date by using constructors or operators like addMonth, it will throw exception. This way all of the dates are valid and it's the user's responsibility to catch exceptions or avoid it in the first place. I think this is the way that libraries like joda-time in Java handle this issue.

What is your opinion ?
@NaarGes

from shamsi_date.

yes thank you, prevention of creating invalid dates is a good idea and it can be done by throwing an error.

from shamsi_date.

I've handled this case manually

from shamsi_date.