in libfdo_data, when we load an empty []byte - we are not getting nil we get a panic. about fido-device-onboard-rs HOT 9 CLOSED

@Avielyo10 why are you using that? that's just a test script - you should borrow from that and just consume the API in your own Go code

from fido-device-onboard-rs.

I created a wrapper around the lib, I'm not using the test script.
This function is critical for using the lib, shouldn't the lib provide the validation?

from fido-device-onboard-rs.

@runcom https://github.com/Avielyo10/edge-api/blob/fdo-client/pkg/services/ownershipvoucher/ownershipvoucher.go#L20

from fido-device-onboard-rs.

@runcom https://github.com/Avielyo10/edge-api/blob/fdo-client/pkg/services/ownershipvoucher/ownershipvoucher.go#L20

oh so that was a bad link at the top :) - would be helpful if you provide the panic as well - @puiterwijk ?

https://github.com/Avielyo10/edge-api/blob/fdo-client/pkg/services/ownershipvoucher/ownershipvoucher.go#L21 (defer comes after you check for nil also)

from fido-device-onboard-rs.

Yes sorry, my bad lol

defer comes after you check for nil also

Because in case I'm returning because of a nil I want it to be invoked

from fido-device-onboard-rs.

panic will crush the server, unless I'll create recover() - a bit redundant for this specific case IMO

from fido-device-onboard-rs.

Right, we really should not be panicking. Is there any chance you could share the panic, as @runcom mentioned, as that is a critical bug to us.

from fido-device-onboard-rs.

Okay, reproduced it, and will make sure this gets fixed.

from fido-device-onboard-rs.

thanks @puiterwijk

from fido-device-onboard-rs.