[feature request] provide a way to swallow error in error hooks about feathers-hooks HOT 5 CLOSED

One way this is already possible would be to .catch the promise and return a normal value instead of throwing another error. So in the hook you could add a result property to the error object, then check for it in the catch and return it like so:

app.service('myservice').create().catch(error => {
  if(error.result) {
    return error.result;
  }

  throw error;
});

I think it wouldn't be very hard to add as a feature either. Basically we just have to change https://github.com/feathersjs/feathers-hooks/blob/master/src/hooks.js#L105 to

.then(hook => {
  if(hook.error) {
    return Promise.reject(hook.error);
  }

  return hook.result;
});

from feathers-hooks.

This will be available in the next version of Feathers core which will include feathers-hooks.

Closed via feathersjs/feathers#621

from feathers-hooks.

Or like in before hooks: if in error hook the hook.result is set, then the error is swallowed, and the hook.result is returned as if the service method succeeds as normal.

from feathers-hooks.

@daffl Yes in old days without error hooks, I was using .catch to do this. However, .catch has to be written after the method calling code (as your example shows), and it is way better to hide this kind of logic into error hooks so the users of the service just call app.service('xxx') and no need to care about the .catch thing.

from feathers-hooks.

nice～!

from feathers-hooks.