Performance optimizations about hooks HOT 8 CLOSED

It's the reflection between context.arguments and the named parameters that slows everything down.
If I replace this piece of code with only context.arguments = args; then it works without additional slowness.

From:

Baseline 20
Empty hooks 195
Single simple hook 268
Single hook and withParams 910
Single hook, multiple withParams 1531
Single hook, multiple withParams (no named) 250

To

Baseline 16
Empty hooks 180
Single simple hook 230
Single hook and withParams 232
Single hook, multiple withParams 365
Single hook, multiple withParams (no named) 221

from hooks.

That was my suspicion, too. Basically the Object.defineProperty should happen once when the function is wrapped instead of every time it is run which makes a huge difference. I have some ideas on a more performant hook context initializer that does this, I will share it here when I gave it a test run.

from hooks.

I wonder if a Proxy (https://developer.mozilla.org/fr/docs/Web/JavaScript/Reference/Objets_globaux/Proxy) would be the solution?

from hooks.

Using a Proxy gives better results:

Baseline 15
Empty hooks 181
Single simple hook 202
Single hook and withParams 409
Single hook, multiple withParams 546
Single hook, multiple withParams (no named) 214

I opened a PR with that: #29

from hooks.

The other thing that slows down a lot is the Object.seal(context.arguments)

With Object.seal:

Baseline 14
Empty hooks 174
Single simple hook 197
Single hook and withParams 476
Single hook, multiple withParams 462
Single hook, multiple withParams (no named) 177

Without Object.seal:

Baseline 16
Empty hooks 130
Single simple hook 124
Single hook and withParams 283
Single hook, multiple withParams 292
Single hook, multiple withParams (no named) 128

jsPerf: https://jsperf.com/object-seal-freeze

from hooks.

My final result:

Baseline 14
Empty hooks 122
Single simple hook 128
Single hook and withParams 285
Single hook, multiple withParams 277
Single hook, multiple withParams (no named) 116

from hooks.

I started a branch in https://github.com/feathersjs/hooks/tree/dl/hook-manager to add to #22 and did some refactoring to see if there is room for improvements using a custom context class where things like argument names are defined once on the protoype instead of every function call. These are the results I am seeing with the benchmark at the moment:

Baseline 14
Empty hooks 120
Single simple hook 147
Single hook and withParams 143

I haven't had a chance to see if it plays well with feathersjs/feathers#1798 yet though.

from hooks.

Amazing, haven't you made the changes on decorator.js or is it an oversight?
The other thing is that the enumerable props and params are not really enumerable with getContextClass.

from hooks.