Giter VIP home page Giter VIP logo

Comments (15)

FedeDP avatar FedeDP commented on August 24, 2024 1

Hi! There were some bugs in Clight 4.10 related to old config management; can you try to upgrade to Clight-git? It should solve those issues!
Also, I need to find the spare time to release Clight 4.11...

from clight.

FedeDP avatar FedeDP commented on August 24, 2024 1

Hey, i finally took the time to tag Clight 4.11; it should fix your issues; let me know please!

from clight.

FedeDP avatar FedeDP commented on August 24, 2024 1

Anyway, glad you solved the issue! 🚀

from clight.

sonofevil avatar sonofevil commented on August 24, 2024 1

No, you were right, the log entry about which file is being read is based on the verbosity set in /etc/clight/clight.conf, but then the local file overrides that verbosity.

from clight.

sonofevil avatar sonofevil commented on August 24, 2024

Hey, i finally took the time to tag Clight 4.11; it should fix your issues; let me know please!

Thank you, I installed clight-git 4.11.r1.ge256faa-1 and There is no longer any errors about the config, but the transitions are still not smooth and my transition settings are still ignored.

(W)[00:05:34]{opts.c:438}	DPMS_CONF: wrong AC 'timeout' value (<= dimmer timeout). Resetting default value.
(W)[00:05:34]{opts.c:443}	DPMS_CONF: wrong BATT 'timeout' value (<= dimmer timeout). Resetting default value.

Clight
* Software version:		4.12-e256faa
* Global config dir:		/etc/clight
* Global data dir:		/usr/share/clight
* Starting time:		Tue Mar 12 00:05:34 2024

Starting options:

### GENERIC ###
* Verbose (debug):		Disabled
* ResumeDelay:		0

### BACKLIGHT ###
* Smooth trans:		Enabled
* Smooth step:		0.05
* Smooth timeout:		500
* Smooth fixed:		0
* Daily timeouts:		AC 600	BATT 1200
* Nightly timeouts:		AC 2700	BATT 5400
* Event timeouts:		AC 300	BATT 600
* Shutter threshold:		0.00
* Autocalibration:		Enabled
* Pause on lid closed:		Disabled
* Capture on lid opened:		Disabled
* Restore On Exit:		Disabled
* Delay on hotplug:		0

### SENSOR ###
* Captures:		AC 5	BATT 5
* Device:		Unset
* Settings:		Unset

### KEYBOARD ###
* Timeouts:		AC 15	BATT 5

### GAMMA ###
* Smooth trans:		Enabled
* Smooth steps:		50
* Smooth timeout:		300
* Daily screen temp:		6500
* Nightly screen temp:		4000
* Long transition:		Enabled
* Ambient gamma:		Enabled
* Restore On Exit:		Disabled

### DAYTIME ###
* User position:		Unset
* User set sunrise:		Unset
* User set sunset:		Unset
* Event duration:		1800
* Sunrise offset:		0
* Sunset offset:		0

### DIMMER ###
* ENTER Smooth trans:		Enabled
* ENTER Smooth step:		0.05
* ENTER Smooth timeout:		10000
* ENTER Smooth fixed:		0
* EXIT Smooth trans:		Enabled
* EXIT Smooth step:		0.05
* EXIT Smooth timeout:		10000
* EXIT Smooth fixed:		0
* Timeouts:		AC 9999	BATT 9999
* Backlight pct:		0.01

### DPMS ###
* Timeouts:		AC 900	BATT 300

### SCREEN ###
* Timeouts:		AC 30	BATT -1

### INHIBIT ###
* Docked:		Disabled
* PowerManagement:		Enabled
* Backlight:		Disabled

(I)[00:05:34]{main.c:145}	Clightd found, version: 5.10-bc3b2e5.
(I)[00:05:34]{keyboard.c:159}	Keyboard backlight calibration unsupported.
(I)[00:05:34]{interface.c:176}	Monitoring requests to org.freedesktop.ScreenSaver name owner.
(I)[00:05:34]{upower.c:55}	AC cable connected.
(I)[00:05:34]{upower.c:66}	Laptop lid opened.
(W)[00:06:04]{location.c:90}	Timed out waiting on location provided by Geoclue2. Killing module.
(W)[00:06:04]{daytime.c:72}	No location provider found; fallback to DAY daytime.
(W)[00:06:04]{gamma.c:93}	Killing GAMMA as no location provider is available.
(I)[00:06:05]{backlight.c:522}	Ambient brightness: 0.213, Screen brightness: 0.510 -> Screen backlight: 0.279.
(W)[00:06:05]{bus.c:199}	Error in async req: unknown
(I)[00:06:34]{backlight.c:522}	Ambient brightness: 0.213, Screen brightness: 0.525 -> Screen backlight: 0.273.
(I)[00:07:04]{backlight.c:522}	Ambient brightness: 0.213, Screen brightness: 0.129 -> Screen backlight: 0.431.
(I)[00:07:34]{backlight.c:522}	Ambient brightness: 0.213, Screen brightness: 0.133 -> Screen backlight: 0.430.
(I)[00:08:04]{backlight.c:522}	Ambient brightness: 0.213, Screen brightness: 0.133 -> Screen backlight: 0.430.
(I)[00:08:34]{backlight.c:522}	Ambient brightness: 0.213, Screen brightness: 0.137 -> Screen backlight: 0.428.
(I)[00:09:04]{backlight.c:522}	Ambient brightness: 0.213, Screen brightness: 0.165 -> Screen backlight: 0.417.
(I)[00:09:34]{backlight.c:522}	Ambient brightness: 0.213, Screen brightness: 0.137 -> Screen backlight: 0.428.
(I)[00:10:03]{signal.c:70}	Received 2. Leaving.


from clight.

FedeDP avatar FedeDP commented on August 24, 2024

Mmmh interesting! Can you enable verbose logs?
Moreover,

Clight abruptly changes backlight brightness in steps of 3-7% which is very jarring.

This is most probably caused by SCREEN module doing its work; does the same happen when you are on battery (ie: when screen module is disabled)?

Also

  • Smooth trans: Enabled
  • Smooth step: 0.05
  • Smooth timeout: 500
  • Smooth fixed: 0

It seems like you have smoothing enabled with a 5% step, therefore it is the expected behavior that backlight is updated with 5% steps.

from clight.

sonofevil avatar sonofevil commented on August 24, 2024

It seems like you have smoothing enabled with a 5% step, therefore it is the expected behavior that backlight is updated with 5% steps.

So the log says, but my actual config looks like this:

    ## Uncomment to disable smooth transitions
    # no_smooth_transition = true;

    ## Transition step in percentage
     trans_step = 0.002;

    ## Transition timeout in ms
     trans_timeout = 1000;
    
    ## When > 0, use a fixed transition duration (in ms),
    ## overriding trans_timeout and trans_step configs.
     trans_fixed = 1000;

from clight.

FedeDP avatar FedeDP commented on August 24, 2024

Is this from backlight.conf config file?
Can you share your /etc/clight/clight.conf and /etc/clight/modules.conf.d/backlight.conf?

from clight.

sonofevil avatar sonofevil commented on August 24, 2024

Extension changed to make shareable:

backlight.conf.txt
clight.conf.txt

I tried setting verbose in clight.conf, but this too gets ignored. Log from --verbose:

(D)[13:48:12]{config.c:413}	Reading config file: /home/lutra/.config/clight.conf
(W)[13:48:12]{opts.c:438}	DPMS_CONF: wrong AC 'timeout' value (<= dimmer timeout). Resetting default value.
(W)[13:48:12]{opts.c:443}	DPMS_CONF: wrong BATT 'timeout' value (<= dimmer timeout). Resetting default value.

Clight
* Software version:		4.12-e256faa
* Global config dir:		/etc/clight
* Global data dir:		/usr/share/clight
* Starting time:		Tue Mar 12 13:48:12 2024

Starting options:

### GENERIC ###
* Verbose (debug):		Enabled
* ResumeDelay:		0

### BACKLIGHT ###
* Smooth trans:		Enabled
* Smooth step:		0.05
* Smooth timeout:		500
* Smooth fixed:		0
* Daily timeouts:		AC 600	BATT 1200
* Nightly timeouts:		AC 2700	BATT 5400
* Event timeouts:		AC 300	BATT 600
* Shutter threshold:		0.00
* Autocalibration:		Enabled
* Pause on lid closed:		Disabled
* Capture on lid opened:		Disabled
* Restore On Exit:		Disabled
* Delay on hotplug:		0

### SENSOR ###
* Captures:		AC 5	BATT 5
* Device:		Unset
* Settings:		Unset

### KEYBOARD ###
* Timeouts:		AC 15	BATT 5

### GAMMA ###
* Smooth trans:		Enabled
* Smooth steps:		50
* Smooth timeout:		300
* Daily screen temp:		6500
* Nightly screen temp:		4000
* Long transition:		Enabled
* Ambient gamma:		Enabled
* Restore On Exit:		Disabled

### DAYTIME ###
* User position:		Unset
* User set sunrise:		Unset
* User set sunset:		Unset
* Event duration:		1800
* Sunrise offset:		0
* Sunset offset:		0

### DIMMER ###
* ENTER Smooth trans:		Enabled
* ENTER Smooth step:		0.05
* ENTER Smooth timeout:		10000
* ENTER Smooth fixed:		0
* EXIT Smooth trans:		Enabled
* EXIT Smooth step:		0.05
* EXIT Smooth timeout:		10000
* EXIT Smooth fixed:		0
* Timeouts:		AC 9999	BATT 9999
* Backlight pct:		0.01

### DPMS ###
* Timeouts:		AC 900	BATT 300

### SCREEN ###
* Timeouts:		AC 30	BATT -1

### INHIBIT ###
* Docked:		Disabled
* PowerManagement:		Enabled
* Backlight:		Disabled

(I)[13:48:12]{main.c:145}	Clightd found, version: 5.10-bc3b2e5.
(D)[13:48:12]{timer.c:34}	Disarmed timerfd on fd 9.
(D)[13:48:12]{my_math.c:73}	AC screen backlight curve: y = -0.037747 + 0.147278x + -0.004520x^2
BL
^
|         **
|        *  
|       *   
|     **    
|           
|    *      
|   *       
|  *        
| *         
|           
**          
+----------->BR
(D)[13:48:12]{my_math.c:73}	BATT screen backlight curve: y = -0.013434 + 0.116361x + -0.003614x^2
BL
^
|           
|           
|         **
|       **  
|      *    
|     *     
|    *      
|   *       
|  *        
| *         
**          
+----------->BR
(D)[13:48:12]{timer.c:32}	Set timeout of 30s 0ns on fd 16.
(D)[13:48:12]{bus.c:189}	init_kbd_backlight(): No such file or directory
(I)[13:48:12]{keyboard.c:159}	Keyboard backlight calibration unsupported.
(D)[13:48:12]{interface.c:175}	Failed to create org.freedesktop.ScreenSaver dbus interface: Unknown error -1
(I)[13:48:12]{interface.c:176}	Monitoring requests to org.freedesktop.ScreenSaver name owner.
(D)[13:48:12]{timer.c:34}	Disarmed timerfd on fd 40.
(I)[13:48:12]{upower.c:55}	AC cable connected.
(I)[13:48:12]{upower.c:66}	Laptop lid opened.
(D)[13:48:12]{interface.c:230}	Emitting 'AcState' property
(D)[13:48:12]{timer.c:32}	Set timeout of 30s 0ns on fd 43.
(D)[13:48:12]{interface.c:230}	Emitting 'LidState' property
(D)[13:48:12]{location.c:152}	Could not find location cache file.
(W)[13:48:42]{location.c:90}	Timed out waiting on location provided by Geoclue2. Killing module.
(W)[13:48:42]{daytime.c:72}	No location provider found; fallback to DAY daytime.
(D)[13:48:42]{interface.c:230}	Emitting 'Location' property
(W)[13:48:42]{gamma.c:93}	Killing GAMMA as no location provider is available.
(D)[13:48:42]{interface.c:230}	Emitting 'DayTime' property
(D)[13:48:42]{timer.c:32}	Set timeout of 30s 0ns on fd 43.
(D)[13:48:42]{timer.c:32}	Set timeout of 0s 1ns on fd 14.
(D)[13:48:42]{backlight.c:442}	Sensor '/dev/video0' is now available.
(D)[13:48:42]{backlight.c:717}	Resumed as a sensor is now available.
(D)[13:48:42]{interface.c:230}	Emitting 'ScreenBr' property
(D)[13:48:42]{interface.c:230}	Emitting 'SensorAvail' property
(D)[13:48:42]{backlight.c:454}	Captured [5/5] from '/dev/video0'. Ambient brightness: 0.906.
(D)[13:48:42]{timer.c:32}	Set timeout of 600s 0ns on fd 14.
(D)[13:48:42]{interface.c:230}	Emitting 'AmbientBr' property
(D)[13:48:42]{interface.c:230}	Emitting 'ScreenBr' property
(D)[13:48:42]{backlight.c:514}	Content calib: wmax: 1.181, wmin: 0.781, new_bl: 1.000
(I)[13:48:42]{backlight.c:522}	Ambient brightness: 0.906, Screen brightness: 0.137 -> Screen backlight: 1.000.
(D)[13:48:42]{interface.c:230}	Emitting 'BlPct' property
(W)[13:48:42]{bus.c:199}	Error in async req: unknown
(D)[13:48:42]{backlight.c:736}	Backlight 'intel_backlight' level updated: 0.18.
(D)[13:48:42]{interface.c:230}	Emitting 'BlPct' property
(D)[13:48:43]{backlight.c:736}	Backlight 'intel_backlight' level updated: 0.23.
(D)[13:48:43]{interface.c:230}	Emitting 'BlPct' property
(D)[13:48:43]{backlight.c:736}	Backlight 'intel_backlight' level updated: 0.28.
(D)[13:48:43]{interface.c:230}	Emitting 'BlPct' property
(D)[13:48:44]{backlight.c:736}	Backlight 'intel_backlight' level updated: 0.33.
(D)[13:48:44]{interface.c:230}	Emitting 'BlPct' property
(D)[13:48:44]{backlight.c:736}	Backlight 'intel_backlight' level updated: 0.38.
(D)[13:48:44]{interface.c:230}	Emitting 'BlPct' property
(D)[13:48:45]{backlight.c:736}	Backlight 'intel_backlight' level updated: 0.43.
(D)[13:48:45]{interface.c:230}	Emitting 'BlPct' property
(D)[13:48:45]{backlight.c:736}	Backlight 'intel_backlight' level updated: 0.48.
(D)[13:48:45]{interface.c:230}	Emitting 'BlPct' property
(D)[13:48:46]{backlight.c:736}	Backlight 'intel_backlight' level updated: 0.53.
(D)[13:48:46]{interface.c:230}	Emitting 'BlPct' property
(D)[13:48:46]{backlight.c:736}	Backlight 'intel_backlight' level updated: 0.58.
(D)[13:48:46]{interface.c:230}	Emitting 'BlPct' property
(D)[13:48:47]{backlight.c:736}	Backlight 'intel_backlight' level updated: 0.63.
(D)[13:48:47]{interface.c:230}	Emitting 'BlPct' property
(D)[13:48:47]{backlight.c:736}	Backlight 'intel_backlight' level updated: 0.68.
(D)[13:48:47]{interface.c:230}	Emitting 'BlPct' property
(D)[13:48:48]{backlight.c:736}	Backlight 'intel_backlight' level updated: 0.73.
(D)[13:48:48]{interface.c:230}	Emitting 'BlPct' property
(D)[13:48:48]{backlight.c:736}	Backlight 'intel_backlight' level updated: 0.78.
(D)[13:48:48]{interface.c:230}	Emitting 'BlPct' property
(D)[13:48:49]{backlight.c:736}	Backlight 'intel_backlight' level updated: 0.83.
(D)[13:48:49]{interface.c:230}	Emitting 'BlPct' property
(D)[13:48:49]{backlight.c:736}	Backlight 'intel_backlight' level updated: 0.88.
(D)[13:48:49]{interface.c:230}	Emitting 'BlPct' property
(D)[13:48:50]{backlight.c:736}	Backlight 'intel_backlight' level updated: 0.93.
(D)[13:48:50]{interface.c:230}	Emitting 'BlPct' property
(D)[13:48:50]{backlight.c:736}	Backlight 'intel_backlight' level updated: 0.98.
(D)[13:48:50]{interface.c:230}	Emitting 'BlPct' property
(D)[13:48:51]{backlight.c:736}	Backlight 'intel_backlight' level updated: 1.00.
(D)[13:48:51]{interface.c:230}	Emitting 'BlPct' property
(D)[13:49:12]{timer.c:32}	Set timeout of 30s 0ns on fd 43.
(D)[13:49:12]{backlight.c:514}	Content calib: wmax: 1.181, wmin: 0.781, new_bl: 1.000
(I)[13:49:12]{backlight.c:522}	Ambient brightness: 0.906, Screen brightness: 0.137 -> Screen backlight: 1.000.
(D)[13:49:12]{interface.c:230}	Emitting 'ScreenBr' property
(D)[13:49:12]{interface.c:230}	Emitting 'BlPct' property
(D)[13:49:12]{backlight.c:736}	Backlight 'intel_backlight' level updated: 1.00.
(D)[13:49:12]{interface.c:230}	Emitting 'BlPct' property
(D)[13:49:12]{backlight.c:736}	Backlight 'intel_backlight' level updated: 0.95.
(D)[13:49:12]{interface.c:230}	Emitting 'BlPct' property

from clight.

sonofevil avatar sonofevil commented on August 24, 2024

I didn't realize there is a /home/lutra/.config/clight.conf. Gimme a minute.

Edit: Ah that must be from running clight -w

from clight.

sonofevil avatar sonofevil commented on August 24, 2024

Well this is odd. It seems that my settings in /etc/ now work after I deleted ~/.config/clight.conf, even though it didn't work before, when that file did not exist. All I have changed is that I added regression points from -w to /etc/clight/modules.conf.d/sensor.conf, although if I comment that out, nothing changes.

I have no explanation for what happened, but the issue seems to be gone. Closing.

from clight.

FedeDP avatar FedeDP commented on August 24, 2024

Are you sure that a local config was not present before? Local config files override global ones, thus that would explain everything!

from clight.

sonofevil avatar sonofevil commented on August 24, 2024

But why didn't the log say it was reading from local config before?

from clight.

FedeDP avatar FedeDP commented on August 24, 2024

Because

(D)[13:48:12]{config.c:413} Reading config file: /home/lutra/.config/clight.conf

That's a debug message only enabled in verbose mode :)

from clight.

sonofevil avatar sonofevil commented on August 24, 2024

Because

(D)[13:48:12]{config.c:413} Reading config file: /home/lutra/.config/clight.conf

That's a debug message only enabled in verbose mode :)

(D)[14:55:31]{config.c:413}	Reading config file: /home/lutra/.config/clight.conf
(W)[14:55:31]{opts.c:438}	DPMS_CONF: wrong AC 'timeout' value (<= dimmer timeout). Resetting default value.
(W)[14:55:31]{opts.c:443}	DPMS_CONF: wrong BATT 'timeout' value (<= dimmer timeout). Resetting default value.

Clight
* Software version:		4.12-e256faa
* Global config dir:		/etc/clight
* Global data dir:		/usr/share/clight
* Starting time:		Tue Mar 12 14:55:31 2024

Starting options:

### GENERIC ###
* Verbose (debug):		Disabled
* ResumeDelay:		0

from clight.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.