Utility function to read samples from a file about chronovise HOT 4 CLOSED

You're right, this was a very ugly hack just for the review. However, in C++ it's very easy to read numbers from a file using ifstream, declaring somewhere (let's say global)

std::ifstream my_input_file ("file.txt"); 

and then in onRun() doing something like this:

float num;
my_input_file >> num;
this->add_sample(num);

I didn't put too much effort in that example, because the user is required to implement the class SimpleExecutionContext or ExecutionContext as he or she desires, but I can fix this horrible hack.

from chronovise.

What I was thinking is that instead of modifying the example, to overload add_sample() in order to get a filename as an argument, since this might be a frequently used feature.

from chronovise.

Ok, I created an utility to read files (4a6a573) and a function add_sample_from_file() in SimpleExecutionContext (a4cc916). The example has been modified accordingly. I didn't use the overload to avoid name hiding problem of the parent class methods.

from chronovise.

I agree, it's fine for me.

from chronovise.