Giter VIP home page Giter VIP logo

Comments (7)

federicomarini avatar federicomarini commented on May 18, 2024

I just checked and it also curiously doesn't work in the local versions either.
Maybe something changed in the way how a modalDialog is handled? OR did we change something and did not update that accordingly?

from genetonic.

federicomarini avatar federicomarini commented on May 18, 2024

Seems to be a problem with the functionality of tippy.
If I remove the fact that the button has a tippy-like feature, this works as expected

I came to think it was that by removing all the "unnecessary things" to make a modal work.
And I "knew" it would work in the simple form as the "session info" modal was still working.

I liked the tippy hint, but we might consider dropping it if that makes the modal not appear as we want.

from genetonic.

federicomarini avatar federicomarini commented on May 18, 2024

Ok, if we change e.g. this

fluidRow(
                  column(
                    width = 1,
                    tippy::tippy(
                      actionButton(inputId = "coder_emap_visnet",
                                   label = "",
                                   style = .helpbutton_biocstyle,
                                   icon = icon("user-edit")),
                      "Show the code for this plot",
                      placement = "right"
                    )
                  )
                )

to this

fluidRow(
                  column(
                    width = 1,
                    actionButton(inputId = "coder_emap_visnet",
                                   label = "",
                                   style = .helpbutton_biocstyle,
                                   icon = icon("user-edit")),
                    tippy::tippy_this(
                      elementId = "coder_emap_visnet",
                      tooltip = "Show the code for this plot",
                      placement = "right"
                    )
                  )
                )

it seems to work.
Maybe there is a way to change least code possible, I will look into it

from genetonic.

federicomarini avatar federicomarini commented on May 18, 2024

Ok, seems with_tippy() instead of the simple tippy() calls we had can simply do it.
Checking on my end, will push.

Can you double check that too @AnnekathrinSilvia and @alpoplaw? You would need to install of course the github version for this (BiocManager::install("federicomarini/GeneTonic"))

from genetonic.

alpoplaw avatar alpoplaw commented on May 18, 2024

from genetonic.

alpoplaw avatar alpoplaw commented on May 18, 2024

from genetonic.

federicomarini avatar federicomarini commented on May 18, 2024

After reinstalling - give a full restart of R at least?
There is that, and also the labels for the gene box

from genetonic.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.