Remove @immutable about equatable HOT 4 CLOSED

Yes, I guess it makes sense; I'd ok with the change as well.

from equatable.

@felangel any plan on working on this issue?

from equatable.

@jorgecoca what are your thoughts on this? While in most cases Equatable is used with the goal of getter closer to data classes, it isn't technically a responsibility of the package itself to enforce this since the package is just concerned with implementing value equality. I'm not opposed to removing the immutable annotation but want to get your thoughts 👍

from equatable.

On second thought it doesn't appear to be a good idea because it's not recommended to override == and hashCode on classes that aren't immutable.

If a class is not immutable, overloading operator == and hashCode can lead to unpredictable and undesirable behavior when used in collections. See https://dart.dev/guides/language/effective-dart/design#avoid-defining-custom-equality-for-mutable-classes for more information.

Going to close this for now but if you disagree feel free to comment and I'm happy to continue the discussion 👍

from equatable.