Giter VIP home page Giter VIP logo

Comments (12)

xxxajk avatar xxxajk commented on September 17, 2024

from uhs30.

xxxajk avatar xxxajk commented on September 17, 2024

Can you issue a pull request for the implementation thus-far without this change so that I may compare it on what MIDI I have here?

from uhs30.

YuuichiAkagawa avatar YuuichiAkagawa commented on September 17, 2024

I send pull request.
I test with Arduino UNO + USB Host Shield only.

If you can use LUFA, you can test it with this code.
https://github.com/YuuichiAkagawa/LUFA_MIDI_Collection

This issue's device is "AKAI MPK mini".

from uhs30.

xxxajk avatar xxxajk commented on September 17, 2024

I have this device too.

from uhs30.

YuuichiAkagawa avatar YuuichiAkagawa commented on September 17, 2024

Additional debug information.
Running with USB_MIDI_Dump.

configuration descriptor
0x0000 09 02 65 00 02 01 00 A0
0x0008 32 09 04 00 00 00 01 01
0x0010 00 00 09 24 01 00 01 09
0x0018 00 01 01 09 04 01 00 02
0x0020 01 03 00 00 07 24 01 00
0x0028 01 41 00 06 24 02 01 01
0x0030 00 06 24 02 02 02 00 09
0x0038 24 03 01 03 01 02 01 00
0x0040 09 24 03 02 04 01 01 01
0x0048 00 09 05 01 02 40 00 00
0x0050 00 00 05 25 01 01 01 09
0x0058 05 81 02 40 00 00 00 00
0x0060 05 25 01 01 03

l:left, r:read, o:offset, d:data
uhs30_midi_debug

from uhs30.

xxxajk avatar xxxajk commented on September 17, 2024

Interesting find. Can you tell me if this change affects other devices negatively?

from uhs30.

YuuichiAkagawa avatar YuuichiAkagawa commented on September 17, 2024

Probably no problem.
But I don't have any other devices. I can't check it.

I can't understand why this code is necessary. I think that it is unnecessary.
https://github.com/felis/UHS30/blob/master/libraries/UHS_host/UHS_host_INLINE.h#L763-L767

                        if(!ei->interface.numep) {
                                rcode = getone(pep, left, read, data, offset);
                                if(rcode)
                                        return rcode;
                        }

from uhs30.

xxxajk avatar xxxajk commented on September 17, 2024

from uhs30.

YuuichiAkagawa avatar YuuichiAkagawa commented on September 17, 2024

I see.
When all interface has no endpoint, I understood this code mean.
But it is wrong when first interface has no endpoint.

I propose PR: #27

My USB MIDI Keyboard is commercial device.
http://www.akaipro.com/product/mpkmini
akaimpkmini

from uhs30.

xxxajk avatar xxxajk commented on September 17, 2024

from uhs30.

xxxajk avatar xxxajk commented on September 17, 2024

Will get a chance to see what the best fix is this coming weekend.

from uhs30.

YuuichiAkagawa avatar YuuichiAkagawa commented on September 17, 2024

Thank you for merge.

from uhs30.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.