Giter VIP home page Giter VIP logo

Comments (8)

Felx-B avatar Felx-B commented on July 20, 2024

Hi
I think you should edit a core vscode file to acheive this, here vscode/src/vs/workbench/services/dialogs/browser/fileDialogService.ts, and then recompile vscode.

You can check out the workbench.ts file in this repo, it is meant to override the core vscode file. You can do the same for the fileDialogService

from vscode-web.

KernelDeimos avatar KernelDeimos commented on July 20, 2024

@Felx-B I tried editing src/vs/workbench/services/dialogs/browser/simpleFileDialog.ts. What's odd is the app is behaving as though I changed nothing, even after I run yarn build and the output indicates success. I even went into dist/out/vs/workbench/workbench.web.main.js and I see the code I wrote in there. I'm kind of at a loss... any idea what I might be missing?

from vscode-web.

coder0107git avatar coder0107git commented on July 20, 2024

You might need to clear your browser cache.

from vscode-web.

KernelDeimos avatar KernelDeimos commented on July 20, 2024

You might need to clear your browser cache.

First thing I tried after I noticed the changes in workbench.web.main.js. I kept clearing it over and over again as though it would change the outcome.

from vscode-web.

coder0107git avatar coder0107git commented on July 20, 2024

Can you please see if the new file is loaded using the builtin browser dev tools?

from vscode-web.

KernelDeimos avatar KernelDeimos commented on July 20, 2024

I still see the original simpleFileDialog.ts from the sources inspector... that's odd. I'm not sure what to make of this, but I'll be investigating it for the next couple of hours.

from vscode-web.

KernelDeimos avatar KernelDeimos commented on July 20, 2024

Is it getting the code from a CDN instead of my build? nvm - I think that's just the sourcemap itself

image

from vscode-web.

KernelDeimos avatar KernelDeimos commented on July 20, 2024

I found the really silly mistake I made (in my building/deployment outside of vscode-web) and it's working great now, thanks for the help!

from vscode-web.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.