Misaligned conversion to Vec<u8>: supported? about bitvec HOT 3 CLOSED

Thanks for the report!

You are correct, this is not intended behavior. This is a result of premature optimization on my part in the implementation of BitVec<C, T>::from_bitslice. I had implemented it as cloning the underlying element slice, but the correct behavior is to collect the bits of the source bitslice into a new bitvector.

I have added the following test case,

let bv = bitvec![
	0, 0, 0, 0,
	0, 0, 0, 1,
	1, 0, 0, 0,
	0, 0, 0, 1,
];

let slice = &bv[4 .. 12];
assert_eq!(slice.len(), 8);
assert!(!slice[0]);
assert!(slice[3]);
assert!(slice[4]);
assert!(!slice[7]);

let bv2 = slice.to_owned();
assert_eq!(bv2, slice);
assert!(!bv2[0]);
assert!(bv2[3]);
assert!(bv2[4]);
assert!(!bv2[7]);

to demonstrate correct behavior.

from bitvec.

That was super fast! Thanks for your fix :)

from bitvec.

I had to force-push an amended commit, make sure you're using 82563fe.

from bitvec.