Giter VIP home page Giter VIP logo

Comments (4)

fewieden avatar fewieden commented on August 23, 2024 1

@danhuss the match list wasn't filtered anymore at all based on focus_on, it only added the teams to the list if they were on bye week. I'm filtering now also the match list.

You can check out the work in progress on the develop branch, since I want to make some more adjustments to the module before releasing a new version.

cd ~/MagicMirror/modules/MMM-NFL
git checkout develop
git pull
npm ci

Also a note to your config option colored. The value should be a boolean true or false. You wrapped it in quotes which changes the type to a string. A string always get's treated as true, except when the string is empty. In your case, it works because you want it to be true, but if you change it for a test to "false" you will see that it still gets treated as true. I suggest changing it, this might cause you trouble when configuring other modules and you wrap booleans in quotes.

from mmm-nfl.

fewieden avatar fewieden commented on August 23, 2024

Hi @danhuss, do you mind sharing your config for MMM-NFL? Last season I switched out the data source, maybe something broke there, or maybe it is related to the pre-season.

I won't judge you for your favorite team 😜

from mmm-nfl.

danhuss avatar danhuss commented on August 23, 2024

Panthers all the way... I do just like to keep an eye on the rest of the division as well.

            {
                    module: "MMM-NFL",
                    position: "bottom_left",
                    config: {
                            focus_on: ["CAR", "ATL", "NO", "TB"],
                            colored: "true"
                    }
            },

from mmm-nfl.

fewieden avatar fewieden commented on August 23, 2024

@danhuss I already did the other stuff 😄 I just released version 1.3.1 which contains the fix, so you only have to update the module, no need to switch to the develop branch

from mmm-nfl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.