Giter VIP home page Giter VIP logo

Comments (2)

fhunleth avatar fhunleth commented on July 3, 2024

Thanks for digging into this and for posting a really detailed issue.

The "legacy" reason for microseconds and the one second timeout is too old and makes no sense. I had forgotten about that.

I think deleting the lines checking that the brutal_kill_wait_ms is less than a second is an easy change and if you want to PR it, I'll merge it quickly.

I'm also for getting rid of the legacy microseconds and bumping the version number to indicate a breaking change. I want to check some code that uses muontrap first just in case there's something I'm missing. I'll try to do that some time this weekend.

from muontrap.

AlmiS avatar AlmiS commented on July 3, 2024

Thank you for a quick response. I will open a PR to remove the check some time during this weekend.

from muontrap.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.