Comments (2)
Thanks for digging into this and for posting a really detailed issue.
The "legacy" reason for microseconds and the one second timeout is too old and makes no sense. I had forgotten about that.
I think deleting the lines checking that the brutal_kill_wait_ms
is less than a second is an easy change and if you want to PR it, I'll merge it quickly.
I'm also for getting rid of the legacy microseconds and bumping the version number to indicate a breaking change. I want to check some code that uses muontrap first just in case there's something I'm missing. I'll try to do that some time this weekend.
from muontrap.
Thank you for a quick response. I will open a PR to remove the check some time during this weekend.
from muontrap.
Related Issues (13)
- Attempt to convert args to binaries HOT 3
- Log stderr when running a daemon
- Windows support. HOT 4
- Fails to compile when there's a space somewhere in the absolute path HOT 4
- Establishing/Supervising Communications With a Long-Running, Data Streaming Python Process HOT 3
- Muontrap.Daemon Proposal HOT 8
- Escript Troubles HOT 8
- No Works with Nerves HOT 3
- cgroup support no longer working on Linux 5.15
- Compiler error on Ubuntu 20.04
- Add test to verify killing chatty processes
- Support new/updated logger levels
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from muontrap.