Giter VIP home page Giter VIP logo

Comments (3)

filips123 avatar filips123 commented on May 8, 2024

Yes, that's good idea. I could probably also add an option to open only external URLs in new windows.

from pwasforfirefox.

pc-v2 avatar pc-v2 commented on May 8, 2024

could there be right clicking link to open default browser without enabling out of scope? Proton Mail do open default browser window while launching it at startup, with open out of scope default window enabled.

from pwasforfirefox.

filips123 avatar filips123 commented on May 8, 2024

I could probably also add an option to open only external URLs in new windows.

Actually, I cannot do this so easily, because browser.link.open_newwindow is static for all URLs and it is hard to manually interject every link on websites and check where should it open. I may do this in the future, but it is currently not planned.

However, when linksTarget is set to 2, forcing links to open in a new window, only the new window is closed and the original PWA window is kept. This might be a better default than opening the links in the current window (when openOutOfScopeInDefaultBrowser is set, that is).

@PeterCxy I will make that switching openOutOfScopeInDefaultBrowser from Firefox settings page will set linksTarget's value. Users can still change it later if they want. However, this only applies to the Firefox settings page and not to changes made in about:config.

could there be right clicking link to open default browser without enabling out of scope?

@pc-v2 I will add this in the next version.

from pwasforfirefox.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.