Giter VIP home page Giter VIP logo

Comments (8)

sbalkee avatar sbalkee commented on May 23, 2024
  1. Research the above solutions

from herd-mdl.

kenisteward avatar kenisteward commented on May 23, 2024

You can mark this as closed when the the first solution is implemented in the CFT for when cloudfront is not used with only an s3 static web page configuration.

The solution is to simply set the Error Page for s3 static web page to index.html

The solution for cloudfront is already implemented inside the CFT for Cloudfront which was to set a custom error response for 404's as index.html/200.

from herd-mdl.

aniruddhadas9 avatar aniruddhadas9 commented on May 23, 2024

@kenisteward But we don't want to show them error. we will redirect them to the page where they come from. Like if they are trying to access baseUrl/data-entities/nsx/xxx they need to be go to that page as well. Will configuring 404's as index.html/200 will redirect to data-entities/nsx/xxx if they came from that page?

from herd-mdl.

kenisteward avatar kenisteward commented on May 23, 2024

@aniruddhadas9 the error won't be shown with the config i gave.

from herd-mdl.

nateiam avatar nateiam commented on May 23, 2024

from herd-mdl.

sbalkee avatar sbalkee commented on May 23, 2024

We have this story in the current sprint. We need to test with both Auth and No-Auth scenarios, as we use Cloudfront and S3 bucket implementations respectively. @rongwang0930 found that we need to make a change for No-Auth case (index.html for S3). We have not tested this with Cloudfront yet. So, we will continue this when we start the story. Thanks @kenisteward and @aniruddhadas9 for looking into this.

from herd-mdl.

kenisteward avatar kenisteward commented on May 23, 2024

@nateiam the smoke tests that are coupled with the app actually will tell you if this fails or not. they just need to be configured to run.

from herd-mdl.

nateiam avatar nateiam commented on May 23, 2024

Verified in no-auth
In Auth, the deep links work -- but it will prompt you for auth anytime you reload or use a deep link

from herd-mdl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.