isSupported returns false positive about firebase-js-sdk HOT 7 OPEN

Hi @ptahchiev, thanks for bringing this to our attention. I tried replicating, but I wasn't able to reproduce the error. If I can replicate the issue, I can have a better look into it. Please share a minimal, but complete sample of a project that I can run locally.

from firebase-js-sdk.

Just checking to ensure that your code is correct.

Are you invoking if(isSupported()) or just checking if it's defined if(isSupported). Looks like the latter is in the test case above.

Thanks!

from firebase-js-sdk.

Here's a reproducible site:
https://ptahchiev.github.io/test-firebase/
with repository:
https://github.com/ptahchiev/test-firebase/
and result:

from firebase-js-sdk.

Thanks for the minimal repro, @ptahchiev. I was able to replicate the behavior. Let me check what we can do for this issue or bring someone here that can provide more context about it. I’ll update this thread if I have any information to share.

from firebase-js-sdk.

I'm not able to get an iOS emulator running at the moment to repro this, but I think the problem is that isSupported() is an async function, so you would have to do if (await isSupported()). In your sample code, the value of isSupported() isn't actually true, it's a promise, which is truthy, which always causes your if to pass. If you logged the value of isSupported() instead of the string "isSupported() is true", this would show up.

Can I ask what documentation guide or tutorial you used for adding isSupported()? I want to make sure we didn't make a mistake and we add await if needed.

from firebase-js-sdk.

Just dropping in to say I have same issue. I am using await isSupported(). And get same exact experience as OP. My only difference is I am using 10.11.0.

from firebase-js-sdk.

Can you provide a repro like the original poster did?

from firebase-js-sdk.