Giter VIP home page Giter VIP logo

Comments (6)

eliihen avatar eliihen commented on August 24, 2024

I can have a look at this when I get the time. Not sure how to detect a page reload though, do you mind to point me in the right direction?

from websocket-monitor.

janodvarko avatar janodvarko commented on August 24, 2024

Take a look at WsmPanel:

  • There is a method onTabNavigated
  • It's registered as a handler for "navigate" event in onRready
  • It sends a "removeFrames" message to the content (to the iframe where all the ReactJS stuff is)
  • The removeFrames message is handled by WebSocketsView.removeFrames method

You can rename the message and make it more generic (e.g. tabNavigated), and wire the logic related to cleaning up of the dropdown connection list from there (i.e. WebSocketsView.tabNavigated).

Let me know if this isn't clear or you don't have time in following couple of weeks (I am having vacation since Dec 17th and this should be fixed and shipped before that :)

Thanks
Honza

from websocket-monitor.

eliihen avatar eliihen commented on August 24, 2024

Ah, I see. Thanks!

That makes sense, yeah. I'll have some time to work this weekend, so I'm sure we'll manage to work this out by the 17th :)

from websocket-monitor.

janodvarko avatar janodvarko commented on August 24, 2024

Awesome!

from websocket-monitor.

janodvarko avatar janodvarko commented on August 24, 2024

Huh, this took me only 2 months to review :-)
Works for me, thanks!
Honza

from websocket-monitor.

eliihen avatar eliihen commented on August 24, 2024

Hehe, good thing we're not in a hurry :)

from websocket-monitor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.