Giter VIP home page Giter VIP logo

Comments (3)

sylvainraye avatar sylvainraye commented on July 17, 2024

Check if the SCP extension doesn't override the block class "Mage_Catalog_Block_Product_Price" in this case you have a conflict and you need to update regarding your situation. For example setting into the local code pool a clean solution.

from firegento-magesetup.

jwittorf avatar jwittorf commented on July 17, 2024

I tried to rewrite the Catalog_Product_Price_Abstract class with my own module but it doesn't take any effect. Why not just add the following code block to app/code/community/FireGento/MagetSetup/Block/Catalog/Product/Price/Abstract.php to ensure compatiblity with SCP like with the two other modules?

// @codingStandardsIgnoreStart
(...)
// SCP support start
elseif (Mage::getConfig()->getModuleConfig('OrganicInternet_SimpleConfigurableProducts')->is('active', 'true')) {
    
    abstract class FireGento_MageSetup_Block_Catalog_Product_Price_Abstract
        extends OrganicInternet_SimpleConfigurableProducts_Catalog_Block_Product_Price
    {
    }
// SCP support end
} else {
    abstract class FireGento_MageSetup_Block_Catalog_Product_Price_Abstract
        extends Mage_Catalog_Block_Product_Price
    {
    }
}

from firegento-magesetup.

blueskies7777 avatar blueskies7777 commented on July 17, 2024

Hi back,
thanks a lot for this!
In a few days I'll give it a shot:))

Kind regards,
Mario

Am 08.05.2014 um 13:03 schrieb jwittorf [email protected]:

I tried to rewrite the Catalog_Product_Price_Abstract class with my own module but it doesn't take any effect. Why not just add the following code block to app/code/community/FireGento/MagetSetup/Block/Catalog/Product/Price/Abstract.php to ensure compatiblity with SCP like with the two other modules?

// @codingStandardsIgnoreStart

(...)

// SCP support start
elseif (Mage::getConfig()->getModuleConfig('OrganicInternet_SimpleConfigurableProducts')->is('active', 'true')) {

abstract class FireGento_MageSetup_Block_Catalog_Product_Price_Abstract
    extends OrganicInternet_SimpleConfigurableProducts_Catalog_Block_Product_Price
{

}

// SCP support end
} else {

abstract class FireGento_MageSetup_Block_Catalog_Product_Price_Abstract
    extends Mage_Catalog_Block_Product_Price
{

}

}

Reply to this email directly or view it on GitHub.

from firegento-magesetup.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.