Implememt fallback mechanism for setup config files about firegento-magesetup HOT 4 CLOSED

My approach would be to extend the config node "magesetup" in etc/config.xml. After the node "available_countries" I would add a new node "hierarchy_countries" where we can nest countries in each other to represent the ancestry. So, for your proposed example it would look like following:

<!-- ... -->
    <magesetup>
        <available_countries>
            <!-- ... -->
        </available_countries>
        <hierarchy_countries>
            <default>
                <de>
                    <at />
                </de>
            </default>
        </hierarchy_countries>
    </magesetup>
<!-- ... -->

If it's ok to you, I would implement it that way.

from firegento-magesetup.

Hi @mryvlin good idea I think.
How deep do we want to support ? One level fallback or more. My point of view is to stay at one level

<!-- ... -->
    <magesetup>
        <available_countries>
            <!-- ... -->
        </available_countries>
        <hierarchy_countries>
            <default>
                <de>
                    <at />
                    <ch />
                </de>
                <fr>
                    <ch />
                </fr>
            </default>
        </hierarchy_countries>
    </magesetup>
<!-- ... -->

from firegento-magesetup.

Hi @diglin
I think that one level should be enough.
But you have a good point in your example - there is currently ch extending two languages (de and fr), wich is not quite correct from my point of view. In this case we would have conflicts extending a language from two others. My approach would be to create two languages for ch, ch_de and ch_fr. As it's either swiss german or swiss french, it would be both semantically and programmaticaly correct.
What do you think?

from firegento-magesetup.

Currently out of scope. We would happily merge a pull-request for this issue.

from firegento-magesetup.