Comments (3)
I like this and it would be easy to implement in the algolia-button
component. We should also bind the the esc key to close the search.
from fireship.io.
@codediodeio Can I try working on this?
from fireship.io.
Yes, please do. I think the best approach is to setup hostlisteners here https://github.com/fireship-io/fireship.io/blob/master/components/src/app/algolia/algolia-search/algolia-search.component.ts. Something like:
@HostListener('document:keydown.escape', ['$event']) onSearchClose(event: KeyboardEvent) {
this.toggle(false)
}
Also, there are existing cypress tests that you can use to validate the integration.
from fireship.io.
Related Issues (20)
- No autofocus when opening search bar modal HOT 2
- The Enterprise has the browser built-in number incrementer
- The size of cards in the labs section are non-uniform HOT 1
- Svelte Kit Course issues HOT 1
- Discord Link is invalid HOT 1
- TYPO on next.js course HOT 1
- forgot the word bytes in lesson
- Typos & broken link in /lessons/typescript-design-patterns/ HOT 1
- Homepage - First letter of Nav Buttons to be made Capital Letters HOT 2
- First letter needs to be capitalized in paragraph on homepage HOT 3
- Configuring my own stripe products HOT 4
- Card Layout Issue: One Card Is Small, One Card Is Large HOT 1
- Snippet - Crontab - Grammar Issues
- API keys shown in algolia-search.svelte
- Change email lost access
- issue in buying a course HOT 1
- Optional Chaining
- Dream app openai dall-e no longer free.
- Can't access Pro features until I have a more 'stable internet connection'
- SvelteKit Full Stack Course - AuthCheck Lesson label error
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fireship.io.