Comments (5)
is this fixed if you pull latest master and apply
diff --git a/src/libc.rs b/src/libc.rs
index 144201f37..857112b11 100644
--- a/src/libc.rs
+++ b/src/libc.rs
@@ -31,7 +31,7 @@ extern "C" {
fn C_CS_PATH() -> i32;
}
-pub static _PATH_BSHELL: AtomicPtr<i8> = AtomicPtr::new(std::ptr::null_mut());
+pub static _PATH_BSHELL: AtomicPtr<c_char> = AtomicPtr::new(std::ptr::null_mut());
extern "C" {
pub fn C_PATH_BSHELL() -> *const c_char;
}
?
from fish-shell.
Is PATH_BSHELL ever not "/bin/sh" anywhere? I would be in favor of just hardcoding that, tbh.
from fish-shell.
yeah we can do that
from fish-shell.
using c_char as you suggested works.
from fish-shell.
This is a good find, thank you!
from fish-shell.
Related Issues (20)
- cd with wildcards behaves differently in 3.7.0 than in 3.6.4 HOT 1
- Mark indicators appear in iTerm2 with fish 3.7.0 HOT 4
- vi mode: user created shortcuts/bindings always exit insert mode HOT 1
- vi mode: output of user-created bindings can be erased while entering insert mode HOT 1
- `ctrl+s` no longer focuses the search box HOT 3
- alias should not add anything HOT 1
- `{capitalize,downcase,upcase}-word` freeze fish and cause 100% CPU usage
- dnf completions lack config-manager subcommand HOT 5
- custom bindings are ignored when using vi key bindings HOT 1
- abbr and pipesign doesnt work as expected HOT 1
- Building fish failing on OpenSUSE Tumbleweed due to ncurses HOT 4
- set_color: Unknown color 'ff80' HOT 2
- `command` doesn't work properly when ran from a variable HOT 5
- Interrupted system call (open) not handled on redirection to fifo
- Tab completion inside braces insert text after closing brace
- add a rust-toolchain.toml to pin the rust version? HOT 1
- Buy a coffee / Donate? HOT 1
- Automatically quote URLs pasted to shell HOT 1
- Fish is not very usable within "win" dumb terminal emulator of Acme text editor HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fish-shell.