Giter VIP home page Giter VIP logo

Comments (5)

krobelus avatar krobelus commented on June 2, 2024

is this fixed if you pull latest master and apply

diff --git a/src/libc.rs b/src/libc.rs
index 144201f37..857112b11 100644
--- a/src/libc.rs
+++ b/src/libc.rs
@@ -31,7 +31,7 @@ extern "C" {
     fn C_CS_PATH() -> i32;
 }
 
-pub static _PATH_BSHELL: AtomicPtr<i8> = AtomicPtr::new(std::ptr::null_mut());
+pub static _PATH_BSHELL: AtomicPtr<c_char> = AtomicPtr::new(std::ptr::null_mut());
 extern "C" {
     pub fn C_PATH_BSHELL() -> *const c_char;
 }

?

from fish-shell.

faho avatar faho commented on June 2, 2024

Is PATH_BSHELL ever not "/bin/sh" anywhere? I would be in favor of just hardcoding that, tbh.

from fish-shell.

krobelus avatar krobelus commented on June 2, 2024

yeah we can do that

from fish-shell.

freqmod avatar freqmod commented on June 2, 2024

using c_char as you suggested works.

from fish-shell.

zanchey avatar zanchey commented on June 2, 2024

This is a good find, thank you!

from fish-shell.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.