Comments (4)
here an strace.
the only EACCES occurs in line 2947, followed by printing the error message:
2947 openat(AT_FDCWD, "/srv", O_RDONLY|O_CLOEXEC) = -1 EACCES (Permission denied)
2948 write(2, "cd: Permission denied: '/srv'\n", 30) = 30
from fish-shell.
builtins/cd.rs
calls fds::wopen_dir
, which calls fds::open_dir
, which sets O_RDONLY
. changing it to O_PATH works for me on Linux, but is neither portable nor correct for a function called open_dir
But it looks like open_dir is only used in cd and in the parser to initialize LibraryData::cwd_fd
.
It also seems like cwd_fd is never read (grep does not find usages, and it still builds when changing it to pub(crate) in struct LibraryData.)
so can we just remove the functions, skip the filedescriptor and directly chdir
? this would be portable to platforms without O_PATH
(like it seems, macos) or O_SEARCH
(all platforms, even if this is specified by posix)
from fish-shell.
If we want to keep cwd_fd
, we can first chdir
and then open(".", ...)
(as done in the Parser
's constructor).
As cwd_fd is an Option, this would be ok to fail.
The flag can be O_SEARCH
, O_SEARCH
or O_RDONLY
, whatever is supported on the platform.
from fish-shell.
Fixed by merging #10442.
from fish-shell.
Related Issues (20)
- Test failures pre 3.8.0 HOT 6
- Configure `backward-kill-path-component` to count `-` as a separator? HOT 3
- Add an easy way to retry a command until it succeeds HOT 1
- Undenied permission with brew? HOT 8
- Fish git prompt doesn't show (U)pdated but (U)nmerged changes HOT 2
- No $status even though it's reported it exists HOT 2
- fish_history corrupted with NUL bytes HOT 1
- Oh, I have to pass the argument with quotes, I see. But this one is not working for me HOT 1
- fish_variables has too large size make fish has a significant delays during startup HOT 1
- Different descriptions of Universal variables in the documentation HOT 1
- Transient prompt doesn't work on recent git master builds
- Terminal protocols spew a *lot* of output
- Android install tutorial in README.md HOT 1
- Alias escaping HOT 1
- Feat: In commands such as `edit_command_buffer` set an environment variable to let the editor config setup custom behaviour HOT 3
- Paging command output as if it was written to a terminal HOT 2
- fish became slow because checking two tools HOT 7
- Not able to `ctrl+c` out of `fzf`
- fish hangs in futex() during start in VS Codeβs integrated terminal HOT 8
- Flatpak completions include the author of the application preceded by a bunch of spaces HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fish-shell.