Shouldn't `react` and `react-dom` be listed as peer dependencies? about react-toastify HOT 5 CLOSED

Thanks for the precision, I understand better know 😁. I'll fix it tonight.

from react-toastify.

Hello @lorenzos,
Last week I was asking myself: "react should be considered a dependency or a peer dependency ?"
Then I forgot about it 😮.

If I define react as a peer dependency, it means that when you install the package you always get the latest version of react? Am I right?

After reading that : dependency types

I totally agree with you.

from react-toastify.

Ok, I should have read the title 2 times.
Sorry for the spam

from react-toastify.

If I define react as a peer dependency, it means that when you install the package you always get the latest version of react? Am I right?

I can be wrong, but I think you're exactly not right 😄 The peer dependency is made exactly for the purpose of not be downloaded as a required dependency of your package. It means something like this package should go along this one, but it'll be the user of my package to specify it as a dependency of her app. And, thinking about it, that's what all React components should do (and in fact, everyone else do).

If you want to dig deeper, I suggest you this: https://nodejs.org/en/blog/npm/peer-dependencies/

from react-toastify.

@lorenzos package updated thanks for the advice !

from react-toastify.