Consider using HTTP keep-alive in fetch calls about flagsmith-nodejs-client HOT 6 CLOSED

@kyle-ssg we were also thinking it might be possible to do either DNS pre-fetching or SSL warming as well if the HTTP client allows it

from flagsmith-nodejs-client.

I should add there may be considerations here in the infrastructure side. You might want to consider your idle timeouts and the maximum number of connections your web-server has configured.

from flagsmith-nodejs-client.

Understood RE keep-alive.

@kyle-ssg we were also thinking it might be possible to do either DNS pre-fetching or SSL warming as well if the HTTP client allows it

I'd imagine people would construct an instance of Flagsmith outside of requests/functions. With that being the case, wouldn't that already be essentially done as part of the first request in local evaluation?

from flagsmith-nodejs-client.

I should add there may be considerations here in the infrastructure side. You might want to consider your idle timeouts and the maximum number of connections your web server has configured.

Considering this, what do we think about adding an optional agent as part of the Flagsmith class properties?

Example:

const agentOptions: AgentOptions = { keepAlive: true, keepAliveMsecs: 6000 };
const httpAgent = new http.Agent(agentOptions);
const httpsAgent = new https.Agent(agentOptions);
const agent = (_parsedURL:URL) => _parsedURL.protocol == 'http:' ? httpAgent : httpsAgent;


....

const flagsmith = new Flagsmith({
    environmentKey,
    agent,
    ...
});

Or, do some of this internally and have

const agentOptions: AgentOptions = { keepAlive: true, keepAliveMsecs: 6000 };
....

const flagsmith = new Flagsmith({
    environmentKey,
    agentOptions,
    ...
});

from flagsmith-nodejs-client.

I realised actually the ability to supply a custom agent would allow for proxy support, so I think we'll go with that.

const agent = require('https-proxy-agent');
const flagsmith = new Flagsmith({
    environmentKey,
    agent,
    ...
});

from flagsmith-nodejs-client.

https://github.com/Flagsmith/flagsmith-nodejs-client/blob/main/examples/custom-fetch-agent/src/api/index.js

from flagsmith-nodejs-client.