Giter VIP home page Giter VIP logo

Comments (8)

spydon avatar spydon commented on June 10, 2024

What Flame version is this with? As far as I know we've never had a method with this signature in TapCallbacks (but I might be wrong):

  bool onTapDown(TapDownEvent event) {

That bool return is from the old events

from flame.

NathanielAJohnson avatar NathanielAJohnson commented on June 10, 2024

Its the hover events that are an issue. I added the onTapDown event handler to test if it was a problem too (and it is). The version of Flame is 1.15.
from ~/.pub-cache/hosted/pub.dev/flame-1.15.0/lib/src/events/flame_game_mixins/multi_tap_dispatcher.dart

/// Called when the user touches the device screen within the game canvas,
  /// either with a finger, a stylus, or a mouse.
  ///
  /// The handler propagates the [event] to any component located at the point
  /// of touch and that uses the [TapCallbacks] mixin. The event will be first
  /// delivered to the topmost such component, and then propagated to the
  /// components below only if explicitly requested.
  ///
  /// Each [event] has an `event.pointerId` to keep track of multiple touches
  /// that may occur simultaneously.
  @mustCallSuper
  void onTapDown(TapDownEvent event) {
    event.deliverAtPoint(
      rootComponent: game,
      eventHandler: (TapCallbacks component) {
        _record.add(TaggedComponent(event.pointerId, component));
        component.onTapDown(event);
      },
    );
  }

from flame.

spydon avatar spydon commented on June 10, 2024

I see, and you said the RectangleComponent was working like it should?
Definitely seems like a bug.

from flame.

NathanielAJohnson avatar NathanielAJohnson commented on June 10, 2024

RectangleComponent behaves correctly. Here is a screen shot that shows how the PolygonComponent reacts to the mouseover event when the mouse is in the inverse quadrant of the debug mode rectangle.
image

from flame.

spydon avatar spydon commented on June 10, 2024

This seems to be the cause: #2930
Edit: That fixed something else though...

from flame.

spydon avatar spydon commented on June 10, 2024

Alright, now I fixed it! (it wasn't the fault of #2930 at all, it just happened to break it).
@NathanielAJohnson can you try depending on the branch (fix/polygon-component-vertices) and see if it fixes the issue for you?

Replace flame with the following in your pubspec to depend on the branch:

dependencies:
  flame:
    git:
      url: https://github.com/flame-engine/flame.git
      ref: fix/polygon-component-vertices
      path: packages/flame

from flame.

NathanielAJohnson avatar NathanielAJohnson commented on June 10, 2024

This fixed it! I also verified it against anchor : Anchor.center and it works as expected. I changed the polygon to a triangle and it worked as well. Thank you.

from flame.

spydon avatar spydon commented on June 10, 2024

Super, thanks for checking!

from flame.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.