context: `RemoteAddr` is unsafe about flamego HOT 3 OPEN

I agree with you, users can implement the ClientIP() method in their custom context.

Maybe we can make a more clear warning message to point out there is a potential security issue. The current warning only shows proxy or VPN can fake the IP address, but the attacker can simply change the request header to do so as well.

from flamego.

This is known and warning has been put in the docs:

I think we should create a new function called ClientIP() to get the client IP address from these headers. The RemoteAddr() can only get it from http.Request.RemoteAddr.

If the user just want the http.Request.RemoteAddr, then they can just call this exact method/field.

Meanwhile, I think if the user wants custom logic, they can just wrap the flamego.Context and implement/override their own version of this method.

Moreover, the Flame instance should allow the developers to set the trusted remote IP headers and the trusted proxies if they want to get the client IP from user-provided headers.

We can provide examples, but I don't think it is worth to complicate the core framework. WDYT?

from flamego.

Maybe we can make a more clear warning message to point out there is a potential security issue. The current warning only shows proxy or VPN can fake the IP address, but the attacker can simply change the request header to do so as well.

Sounds good, feel free to send PRs to docs repos.

from flamego.