Support new MongoDB versions without requiring a new release about de.flapdoodle.embed.mongo HOT 12 CLOSED

Maybe ..
I have to think about it to find a solution which meets both needs..

meanwhile i can make a new release for the new versions

michael

Am Samstag, den 14.07.2012, 14:53 -0700 schrieb Joe Littlejohn:

It would be nice if the API could support any valid version of Mongo without needing a new release and upgrade when new versions become available.

At the moment the plugin itself keeps a full, static list of supported versions which must be updated. Would it be possible to change this to simply try any version given and only reject the version number if the download produces a 404?

---

Reply to this email directly or view it on GitHub:
#8

from de.flapdoodle.embed.mongo.

Maybe we could support both worlds and mark the 'free-text' mongodb version as 'unsupported' unless we make a new release?

from de.flapdoodle.embed.mongo.

Something like this..

Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.

"Martin Jöhren" [email protected] schrieb:

Maybe we could support both worlds and mark the 'free-text' mongodb version as 'unsupported' unless we make a new release?

Reply to this email directly or view it on GitHub:
#8 (comment)

from de.flapdoodle.embed.mongo.

I take a look tomorrow. My inet connection sucks hard here. Happy git fetching..

from de.flapdoodle.embed.mongo.

You should now be able to use a generic version by using:
Distribution d = new Distribution(new GenericVersion("2.2"), Platform.detect(), BitSize.B64);
for example, but you need to make sure that your version exists. Please give it a try and give me some feedback whether it works for you.

from de.flapdoodle.embed.mongo.

Ah great. I'll take a look this evening.

from de.flapdoodle.embed.mongo.

@matlockx this is working well, thanks!!

I notice that when I specify a version that doesn't exist, the MongoDB download server responds with a 403 (funny choice of response status but meh...). This causes an IOException inside MongoDBRuntime#prepare which is swallowed and the method returns null.

It seems like a good idea to throw an unchecked exception here if the download has failed.

from de.flapdoodle.embed.mongo.

I thought about the same point, but I didn't want to change too much in the first step because my test broke on the Jenkins cloud machine but was working locally. I will fix that test next week and then go on with some better exception handling in there. Thanks so far for your insight. Greets, Martin

from de.flapdoodle.embed.mongo.

I did change this, because null is not useful in any case. I did some minor refactoring, so maybe there some little changes if you are using this right now. I will wait two days and will make an release, if nobody has any comments.

from de.flapdoodle.embed.mongo.

.. and i think it's closed.. :)

from de.flapdoodle.embed.mongo.

Great, thanks again. I'm looking forward to the next release :)

from de.flapdoodle.embed.mongo.

release done.. should be in maven central within 24 hrs

from de.flapdoodle.embed.mongo.