Giter VIP home page Giter VIP logo

Comments (14)

franzliedke avatar franzliedke commented on June 3, 2024 1

I created an issue, thanks.

from framework.

franzliedke avatar franzliedke commented on June 3, 2024

80?

from framework.

tobyzerner avatar tobyzerner commented on June 3, 2024

Yeah 80 sounds good.

from framework.

Chigusa0w0 avatar Chigusa0w0 commented on June 3, 2024

Why not let site admins modify the max title length instead of write it into the source code? (but 80 is still a good length for title)
please forgive my poor english

from framework.

franzliedke avatar franzliedke commented on June 3, 2024

One reason that comes to my mind: the limit is probably enforced by database constraints (i.e. the title field in the discussions table).

from framework.

qrokodial avatar qrokodial commented on June 3, 2024

Why not let site admins modify the max title length instead of write it into the source code?

what would be the use-case for modifying the title length? adding customization for the sake of having customization adds unnecessary complexity when there is no realistic reasons for modifying it.

from framework.

jgknight avatar jgknight commented on June 3, 2024

what would be the use-case for modifying the title length?

The use case would be a forum admin wanting to increase or decrease the allowed length of forum titles.. While I agree with not adding complexity, searching around on Google provides a lot of results for people looking to customize the title length of different software (vBulletin, phpBB, etc.) Perhaps it's not a priority for initial release, but it certainly is not in the realm of 'unrealistic' to provide some method to change it.

from framework.

solhuebner avatar solhuebner commented on June 3, 2024

I think this is where the plugin concept can catch up on the end. Like I would like to see it as a bbPress replacement but I think this will not work out of the box. Although it would be awesome ;-)

from framework.

tobyzerner avatar tobyzerner commented on June 3, 2024

Also we should truncate the slug at 40 characters or so.

from framework.

tobyzerner avatar tobyzerner commented on June 3, 2024

What needs to be done:

  • Add a validation rule to the Discussion model to limit the discussion title to 80 characters.

from framework.

franzliedke avatar franzliedke commented on June 3, 2024

Fixed in #338, thanks @lbausch.

from framework.

 avatar commented on June 3, 2024

One reason that comes to my mind: the limit is probably enforced by database constraints (i.e. the title field in the discussions table).

The field title isn't used in foreign keys and therefore has no such restrictions.

80 characters for the title - it's VERY, very little to complete the work: - /

from framework.

franzliedke avatar franzliedke commented on June 3, 2024

@balancer I was referring to the size of the database column, but that is currently set to 200.

from framework.

tobyzerner avatar tobyzerner commented on June 3, 2024

It may as well be set to 255, 200 is kind of arbitrary.

The max title length should be configurable (not necessarily via default UI, but definitely via db settings). Do we have an issue for that elsewhere or should we reopen this one?

from framework.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.