Giter VIP home page Giter VIP logo

Comments (7)

realbigsean avatar realbigsean commented on August 26, 2024

Ok, so if I'm following the changes in this repo correctly, with #53 being merged, the idea is to completely remove mev-boost <> local execution engine communication? If that's the case then it seems fine not to worry about JWT with mev-boost because the purpose of JWT as I understand it is to make sure only a trusted CL controls the forkchoice of an execution engine. And the engine_forkchoiceUpdatedV1 here is being forwarded to the relay only to inform it of a proposer's fork

from mev-boost.

lightclient avatar lightclient commented on August 26, 2024

@realbigsean I think mev-boost will still need to deal with JWT. Lighthouse does not support unauthenticated communication with EL any longer, so if users want mev-boost to drive it, there will need to be support for authenticated communication.

from mev-boost.

realbigsean avatar realbigsean commented on August 26, 2024

Thanks for the response @lightclient !

That's what I was thinking when I opened this issue. But all the calls from mev-boost to the execution layer were removed here, so mev-boost won't drive any communication to a local execution layer. I think limiting mev-boost's role to only payload construction (and not payload verification) is good, which that PR achieves.

The updates to the diagram here I think make the changes clear: https://github.com/flashbots/mev-boost/pull/57/files

The engine_forkchoiceUpdatedV1 call is still communicated to the relay through mev-boost, though. I would guess the relay just build payloads on top of whatever it is given, but I have no idea how it's being implemented (maybe the flashbots team can shed some light here). Maybe the threat of tampering with these calls warrants JWT for consensus layer <> mev-boost communication?

from mev-boost.

lightclient avatar lightclient commented on August 26, 2024

Right, my mistake. Thanks for the correction. In that case, it does seem like authenticating the API is unnecessary as it can't be used to i) disrupt the fork choice or ii) cause the client to sign a block from an untrusted builder.

from mev-boost.

metachris avatar metachris commented on August 26, 2024

engine_forkchoiceUpdatedV1 is no longer communicated to the relay. Is JWT auth still needed for the current v0.2 spec?

from mev-boost.

lightclient avatar lightclient commented on August 26, 2024

I don't think it is.

from mev-boost.

metachris avatar metachris commented on August 26, 2024

Closing this for now. Let's reopen if needed 🙏

from mev-boost.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.