Comments (7)
Ok, so if I'm following the changes in this repo correctly, with #53 being merged, the idea is to completely remove mev-boost <> local execution engine communication? If that's the case then it seems fine not to worry about JWT with mev-boost because the purpose of JWT as I understand it is to make sure only a trusted CL controls the forkchoice of an execution engine. And the engine_forkchoiceUpdatedV1
here is being forwarded to the relay only to inform it of a proposer's fork
from mev-boost.
@realbigsean I think mev-boost will still need to deal with JWT. Lighthouse does not support unauthenticated communication with EL any longer, so if users want mev-boost to drive it, there will need to be support for authenticated communication.
from mev-boost.
Thanks for the response @lightclient !
That's what I was thinking when I opened this issue. But all the calls from mev-boost to the execution layer were removed here, so mev-boost won't drive any communication to a local execution layer. I think limiting mev-boost's role to only payload construction (and not payload verification) is good, which that PR achieves.
The updates to the diagram here I think make the changes clear: https://github.com/flashbots/mev-boost/pull/57/files
The engine_forkchoiceUpdatedV1
call is still communicated to the relay through mev-boost, though. I would guess the relay just build payloads on top of whatever it is given, but I have no idea how it's being implemented (maybe the flashbots team can shed some light here). Maybe the threat of tampering with these calls warrants JWT for consensus layer <> mev-boost communication?
from mev-boost.
Right, my mistake. Thanks for the correction. In that case, it does seem like authenticating the API is unnecessary as it can't be used to i) disrupt the fork choice or ii) cause the client to sign a block from an untrusted builder.
from mev-boost.
engine_forkchoiceUpdatedV1
is no longer communicated to the relay. Is JWT auth still needed for the current v0.2 spec?
from mev-boost.
I don't think it is.
from mev-boost.
Closing this for now. Let's reopen if needed 🙏
from mev-boost.
Related Issues (20)
- Problem upgrading to latest, need to upgrade Go, add to release notes please HOT 6
- Cannot build 1.7 HOT 6
- Different version number to 1.7 HOT 6
- X-Mevboost-Version v1.7.1 HOT 1
- mev-boost: command not found HOT 2
- Spurious `no bid for this getPayload payload found` HOT 5
- Feat: Log a big fat message if the relay with the bid fails to return the payload
- Adding a cli library HOT 2
- MEV-Boost Direct builder connection HOT 5
- Very few proposals and warning in logs
- security exploit HOT 3
- Allow setting a minimum gas used value to determine whether or not to use a block supplied by the builder API HOT 3
- https://github.com/flashbots/mev-boost/releases/download/v1.7/mev-boost_1.7_windows_amd64.tar.gz
- How do I re-enable GET requests on the logs like earlier versions? HOT 1
- how do i go about using this service
- Release of the request start time metrics
- Binary version mismatch: Available version (1.7) lags behind stable version (1.7.1) HOT 1
- invalid payload because bad withdrawals root HOT 12
- Upcoming mev-boost release: v1.8 HOT 5
- Idea: use builder-playground for e2e integration tests
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mev-boost.