preventLastDuplicates only checks active notifications about angular2-notifications HOT 5 CLOSED

You're right, but now i can't decide what the behavior should be? Should it prevent 2 same notifications to show on the screen at the same time, or should i prevent creating a notification equal to the last notification created.

What do you think?

from angular2-notifications.

I would expect the latter to be far more useful. The preventDuplicates flag could be used to prevent most other cases of duplicate notifications being created, and I doubt there's a lot of cases where someone doesn't want duplicate notifications in a row to be created, but wants other duplicates to be allowed. Preventing a notification equal to the last created, though, allows an app to silence a continuous stream of duplicate notifications, which can be useful.

from angular2-notifications.

You're right. I'll modify it to fit the description. Thank you for your insight 👍

from angular2-notifications.

I've actually kept both implementations. In the new library version the preventLastDuplicates option now excepts one of the following values:

• false
• "all"
• "visible"

So if it has the value "all" it prevents duplicates of the last notification created, but if it has the value visible it prevents duplicates of the last visible notification.

I'll add this to the readme later today but it's already published so you can test it out if you want to.

from angular2-notifications.

That sounds great, thanks for the quick fix!

from angular2-notifications.