Giter VIP home page Giter VIP logo

Comments (3)

mongkok avatar mongkok commented on July 17, 2024 1

done!, pip install django-graphql-social-auth >= 0.1.2

from django-graphql-social-auth.

PiDelport avatar PiDelport commented on July 17, 2024

I'm currently working around this with the following small local hack (modification marked with comment):

class GraphQLSocialAuthResultIsNotUser(exceptions.GraphQLSocialAuthError):
    """
    The social auth pipeline result is not a user object.
    """

    def __init__(self, result):
        super().__init__(result)
        self.result = result


def psa(f):
    @wraps(f)
    def wrapper(cls, root, info, provider, access_token, **kwargs):
        strategy = load_strategy(info.context)
        try:
            backend = load_backend(strategy, provider, redirect_uri=None)
        except MissingBackend:
            raise exceptions.GraphQLSocialAuthError(_('Provider not found'))

        user = backend.do_auth(access_token)

        if user is None:
            raise exceptions.GraphQLSocialAuthError(_('Invalid token'))

        # BEGIN local modification
        # Raise non-user result values as GraphQLSocialAuthResultIsNotUser.
        # (Type-checking code referenced from `social_core.actions.do_complete` for consistency.)
        user_model = strategy.storage.user.user_model()
        if user and not isinstance(user, user_model):
            raise GraphQLSocialAuthResultIsNotUser(user)
        # END local modification

        if not issubclass(cls, mixins.JSONWebTokenMixin):
            login(info.context, user)

        social = user.social_auth.get(provider=provider)

        return f(cls, root, info, social, **kwargs)
    return wrapper

My application then uses a SocialAuth subclass to extend mutate to catch GraphQLSocialAuthResultIsNotUser and handle the redirect by returning it as part of the mutation result.

Would something like the above approach be workable for including into the library? It lets applications catch and handle GraphQLSocialAuthResultIsNotUser in their own appropriate way, while for applications that don't the behaviour won't be different than before, except that the raised exception should be clearer and easier to understand than the current AttributeError.

from django-graphql-social-auth.

mongkok avatar mongkok commented on July 17, 2024

@pjdelport Hi and thanks!,
I understand the problem and I think your approach is right.
I would prefer to use the generic exception, see the PR #8.

from django-graphql-social-auth.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.