Giter VIP home page Giter VIP logo

Comments (15)

blittle avatar blittle commented on May 17, 2024

+1 - Please fix :)

from jquery.scrollto.

adjohn avatar adjohn commented on May 17, 2024

+1

from jquery.scrollto.

flesler avatar flesler commented on May 17, 2024

Can you confirm if the pull request fixes the issue?
Thanks and sorry for the delay

from jquery.scrollto.

blittle avatar blittle commented on May 17, 2024

Yes

from jquery.scrollto.

flesler avatar flesler commented on May 17, 2024

Awesome I'm closing it then, re-open if needed

from jquery.scrollto.

adjohn avatar adjohn commented on May 17, 2024

I think you need to retag 1.4.3 for this to work with bower/yeoman.

from jquery.scrollto.

flesler avatar flesler commented on May 17, 2024

I've never used bower or yeoman so really just following your steps, if you find a problem and know how to fix it, tell me how and I'll do it.

from jquery.scrollto.

adjohn avatar adjohn commented on May 17, 2024

The problem is that in git tag "1.4.3" your component.json file specifies
versions of "1.4.3.1". The mismatch causes a problem with Bower and
Yeoman. Also, I believe you can't use a version scheme of x.x.x.x, so you
need to stick with something like 1.4.4 instead of 1.4.3.1. If you change
the component.json to 1.4.3 you then need to delete the current tag "1.4.3"
and re-tag it with the change made to the component.json file.

Let me know if you have any questions.

On Tue, Nov 13, 2012 at 2:18 PM, Ariel Flesler [email protected]:

I've never used bower or yeoman so really just following your steps, if
you find a problem and know how to fix it, tell me how and I'll do it.


Reply to this email directly or view it on GitHubhttps://github.com//issues/24#issuecomment-10346411.

from jquery.scrollto.

hellomedia avatar hellomedia commented on May 17, 2024

I confirm, I am having the same problem.

from jquery.scrollto.

flesler avatar flesler commented on May 17, 2024

Ok, I will re-release 1.4.3.1 as 1.4.2 asap and get done with this :)

On Wed, Nov 14, 2012 at 2:45 PM, Nicolas Sauveur
[email protected]:

I confirm, I am having the same problem.


Reply to this email directly or view it on GitHubhttps://github.com//issues/24#issuecomment-10375877.

Ariel Flesler

from jquery.scrollto.

adjohn avatar adjohn commented on May 17, 2024

That'll work, thanks!

from jquery.scrollto.

flesler avatar flesler commented on May 17, 2024

Ok re-released as 1.4.4 and re-tagged (0a8513e)
Can you verify it's fine now?

from jquery.scrollto.

adjohn avatar adjohn commented on May 17, 2024

Confirmed, it works for Yeoman v0.9.5 and Bower v0.4.0.

Thanks!

On Mon, Nov 19, 2012 at 3:19 PM, Ariel Flesler [email protected]:

Ok re-released as 1.4.4 and re-tagged (0a8513ehttps://github.com/flesler/jquery.scrollTo/commit/0a8513eab987ad85c3e608a03d02566827c91484
)
Can you verify it's fine now?


Reply to this email directly or view it on GitHubhttps://github.com//issues/24#issuecomment-10535910.

from jquery.scrollto.

flesler avatar flesler commented on May 17, 2024

Thanks

from jquery.scrollto.

hellomedia avatar hellomedia commented on May 17, 2024

Thanks

from jquery.scrollto.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.