Giter VIP home page Giter VIP logo

Comments (4)

gazpachoking avatar gazpachoking commented on July 3, 2024 1

Seems like a good feature. I'd say that from_rtorrent could probably just provide all the custom fields (with an rtorrent_ prefix) rather than the user having to specify which ones.

As for setting it, I'd probably put it under a separate dict in the config, something like:

rtorrent:
  custom_fields:
    myspecialfield: whatever
    otherspecialfield: "it should support {{jinja}} too"

A pull request would be great for something like this if you, or someone else, is up for it.

from flexget.

jasonlyle88 avatar jasonlyle88 commented on July 3, 2024

I would love for from_rtorrent to automatically return all custom attributes, however I'm not sure how possible that is. Looking at the documentation, I don't see a way to list the keys for the named custom attributes (unless you have rTorrent-PS installed, which I don't think we want to make a dependency).

As for setting it, I was thinking not using a separate dict in the config just to keep the names the same between from_rtorrent and rtorrent plugins, but I don't think its that big of a deal either way.

Although, I suppose the cleanest way would just be to add the separate custom_fields dict to both from_rtorrent and rtorrent and keep consistency that way!

from flexget.

gazpachoking avatar gazpachoking commented on July 3, 2024

I would love for from_rtorrent to automatically return all custom attributes, however I'm not sure how possible that is. Looking at the documentation, I don't see a way to list the keys for the named custom attributes (unless you have rTorrent-PS installed, which I don't think we want to make a dependency).

Ahh, didn't realize some of those methods on the linked documentation required extra stuff. Not familiar with the rtorrent ecosystem.

Although, I suppose the cleanest way would just be to add the separate custom_fields dict to both from_rtorrent and rtorrent and keep consistency that way!

👍

from flexget.

jasonlyle88 avatar jasonlyle88 commented on July 3, 2024

Functionality added via #3807

from flexget.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.