can't compare offset-naive and offset-aware datetimes about flexget HOT 5 CLOSED

Oh, were you comparing some parsed date to another? That indeed isn't working at the moment if only one specified a timezone.

tasks:
  a_task:
    mock:
      - title: someentry
    set:
      somedate: "2023-12-31T00:00:00+03:00"
      otherdate: "2023-12-31"
      somecomparison: "{{somedate|parsedate < otherdate|parsedate}}"

from flexget.

Good catch. parsedate indeed needs to be updated to use the compatibility class that allows comparing naive to offset aware datetimes. That being said, utcnow and now should already have that feature so I would expect your example to work already. Are you on the latest version? (There were a couple other fixes after the initial merge.) If so, can you give some more details of you example so I can understand how both sides of the comparison somehow avoided getting our custom compatibility layer? Just want to make sure I'm fixing in all the places needed.

Here's the quick test I did which was already working.

tasks:
  a_task:
    mock:
      - title: someentry
    set:
      somedate: "2023-12-31"
      somecomparison: "{{somedate|parsedate < utcnow}}"

from flexget.

This commit will almost certainly fix your issue. I'd like to understand exactly the situation you were running in to though still to make sure all edge cases are captured.

from flexget.

This commit will almost certainly fix your issue. I'd like to understand exactly the situation you were running in to though still to make sure all edge cases are captured.

Yeah, I was comparing two parsedate's, one originated from the new utcnow and thus had timezone information, and the other didn't.

If I were to start from scratch then I would consider timezones for all dates but now I have to deal with the information that I have in the DB so the compat layer is welcome. Thanks!

from flexget.

Ahh, gotcha. Yep, this will fix your issue.

from flexget.