Giter VIP home page Giter VIP logo

Comments (9)

MrTransistorsChannel avatar MrTransistorsChannel commented on August 17, 2024 1

Ok so this may be a little bit off topic.
Latest stable Spigot BuildTools is now 1.17, they just forgot to change the info on their website, so I think that first we will update the plugin to 1.17 and then fix this issue because people want this plugin to be on 1.17 as soon as possible

from autocraft.

MrTransistorsChannel avatar MrTransistorsChannel commented on August 17, 2024 1

@pokemonrocks9 @MrTransistorsChannel release has been updated

@Fliens please remove "added missing recipes" from the Spigot page (I fixed the release note on github already) so people won't spam issues. They will be added soon, I'm working on it for the next release
Sorry for continuing this thread

from autocraft.

MrTransistorsChannel avatar MrTransistorsChannel commented on August 17, 2024

I'm planning on looking into this issue, currently crafting is being done using recipe book which (at least now) gives only the result of the craft and just deletes the incoming materials. Right now the only way I can think of is just force-checking if there's a honey bottle in the crafting recipe and manually adding empty bottles to the result array, but this needs checking because maybe there is a way to get what is left after the crafting is being done.

Please think about some other crafts that can have similar issue with lost items

from autocraft.

Fliens avatar Fliens commented on August 17, 2024

I've also thought of this but as @MrTransistorsChannel said, there is noe 'used' item in the crafting api. It is posible to implement but we would have to add a list of 'used' items like bottles, buckets... and test if one of these items is in the recipe. After successfully crafting, the 'used' item would drop out of the dispenser

from autocraft.

avixk avatar avixk commented on August 17, 2024

Fixed this issue in #5 . I found a little method in the Material class called "getCraftingRemainingItem()" that is used to get remaining items from crafting ingredients. My edits check if there's a remaining item, and makes sure there's enough room for both the product and the remaining items in the output container.

from autocraft.

MrTransistorsChannel avatar MrTransistorsChannel commented on August 17, 2024

This can be closed now, got fixed in #8

from autocraft.

pokemonrocks9 avatar pokemonrocks9 commented on August 17, 2024

will the jar be updated to accommodate the change? It appears the current one is still the same

from autocraft.

MrTransistorsChannel avatar MrTransistorsChannel commented on August 17, 2024

Yeah, @Fliens you should update the spigot page and github release, the plugin is currently v2.2

from autocraft.

Fliens avatar Fliens commented on August 17, 2024

@pokemonrocks9 @MrTransistorsChannel release has been updated

from autocraft.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.