Giter VIP home page Giter VIP logo

Comments (4)

erka avatar erka commented on June 2, 2024

Currently flipt validate allows to specify the files relatively currently directory. You could run it like flipt validate production.yml extra/feature.yml.

if len(args) == 0 {
_, err = fs.SnapshotFromFS(logger, os.DirFS("."), opts...)
} else {
_, err = fs.SnapshotFromPaths(logger, os.DirFS("."), args, opts...)
}

There is no documentation about this use case. @GeorgeMac could you please bring some light on it?

from flipt.

GeorgeMac avatar GeorgeMac commented on June 2, 2024

@erka When flipt validate was initially implemented it only supported taking explicit paths in this way.
This was back when it was a prototype for the GitHub action.
We quickly updated it to make the zero argument form index aware, so that it was inline with how the backends worked, but still backwards compatible. So that flipt validate was a simple catch all, that worked exactly how running git or local over the same directory does.

However, there was a user already taking advantage of the original form, so we left the explicit paths in.

You're right we don't have the old form (explicit paths) document here https://www.flipt.io/docs/cli/commands/validate#behavior on in the CLI help text.

My suggestion here would be to add a flag --workdir or -w instead for this behaviour.

from flipt.

erka avatar erka commented on June 2, 2024

@markphelps are you fine with George's suggestion?

from flipt.

markphelps avatar markphelps commented on June 2, 2024

@markphelps are you fine with George's suggestion?

Yes I think that makes sense!

from flipt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.