Comments (7)
Good catch. I think fips_libs() is currently kind of redundant, can you check whether fips_deps() works for you (like here: https://github.com/floooh/oryol/blob/master/code/Modules/Gfx/CMakeLists.txt#L144)? I'm wondering if I should actually remove the fips_libs() call.
from fips.
... I think there's also a bug in fips_end_lib(), this block is missing which is both in fips_end_module() and fips_end_app(): https://github.com/floooh/fips/blob/master/cmake/fips.cmake#L193
from fips.
You are right, use of fips_deps() works if the missing block is added to fips_end_lib().
Just FYI this triggers a warning if the CMake verbose level is raised:
CMake Warning (dev) at ... (add_dependencies):
Policy CMP0046 is not set: Error on non-existent dependency in
add_dependencies. Run "cmake --help-policy CMP0046" for policy details.
Use the cmake_policy command to set the policy and suppress this warning.
The dependency target "OpenGL32" of target "graphics" does not exist.
This warning is for project developers. Use -Wno-dev to suppress it.
from fips.
Hmm this warning is a side effect of a fix I had to do for code generation where it must be ensured that a target which depends on another target with code generation is built after that code-generation target. Such a target dependency doesn't make sense for existing static link libs... I'll try setting this cmake_policy in fips_setup.
from fips.
PS: I will fix this policy warning in a clean way by actually re-using fips_libs() for this. The idea is that fips_deps() is used for depdencies to cmake targets (defined with fips_begin/end_module() and fips_begin/end_lib()), and fips_libs() for precompiled static link libraries (like OpenGL32).
from fips.
from fips.
Use fips_libs() now to define dependencies to existing static link libs that are not built by the project, this will be recursively resolved like fips_deps() dependencies, but will avoid the policy warning (see here for an example: https://github.com/floooh/oryol/blob/master/code/Modules/Gfx/CMakeLists.txt#L144
from fips.
Related Issues (20)
- c99
- Missing standard math library when build in Ubuntu. HOT 2
- fips diag tools for checking http-server??? HOT 2
- cmake.py/run_build() adds Visual Studio args for Android builds
- Install and CPack ? HOT 2
- MSVC treat warnings as errors HOT 4
- Is this FIPS possible to support VS2010 project? HOT 2
- How to use 'exec_program' in FIPS??? HOT 1
- LNK203 _MSC_VER HOT 2
- I find fips very interesting but ... HOT 1
- Ios Bundle assets and other Xcode settings HOT 3
- "fips run xxxxx" fails on github actions windows vm with "The system cannot find the path specified." HOT 4
- Moving Directories HOT 2
- android SDK changed the folder tree HOT 4
- Slow builds via cmd line HOT 3
- great build system, awesome! HOT 1
- Using --parallel in cmake does not build in parallel within projects HOT 4
- Included PyYaml (yaml3) breaks with python 3.10 HOT 2
- VSCode launch/build target fails HOT 3
- Working with projects outside the fips folder hierarchy is broken HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fips.