Giter VIP home page Giter VIP logo

Comments (18)

jmettraux avatar jmettraux commented on June 15, 2024

Hello @honglooker,

thanks for the detailed error report, I'll be looking into it soon.

We basically want it to run every day from 8am to 7pm with a 4-hour increment, which boils down to 8am, 12pm, and 4pm.

As a workaround, would the simplified "0 8,12,16 * * * America/New_York" work for you?

from fugit.

jmettraux avatar jmettraux commented on June 15, 2024

Notes, in passing:

ENV['TZ'] = 'UTC'

p Time.now
  # 2020-09-15 02:47:23 +0000
p (Time.zone rescue "no Time.zone method")
  # "no Time.zone method"

require 'active_support/time'

p Time.now
  # 2020-09-15 02:47:24 +0000
p Time.zone
  # nil

Time.use_zone('America/New_York') do

  p Time.now
    # 2020-09-15 02:47:24 +0000
  p Time.zone
    # #<ActiveSupport::TimeZone:0x4f2544b0
    #   @name="America/New_York",
    #   @utc_offset=nil, @tzinfo=#<TZInfo::TimezoneProxy: America/New_York>>

  p Time.parse('2020-09-11 12:00:00')
    # 2020-09-11 12:00:00 +0000
  p Time.parse('2020-09-11 12:00:00').zone
    # "UTC"
  p Time.zone.parse('2020-09-11 12:00:00')
    # Fri, 11 Sep 2020 12:00:00 EDT -04:00
  p Time.zone.parse('2020-09-11 12:00:00').zone
    # "EDT"
end

from fugit.

jmettraux avatar jmettraux commented on June 15, 2024

@honglooker what version of the et-orbi gem are you using?

from fugit.

honglooker avatar honglooker commented on June 15, 2024

Hey, thanks for the update.

I tried

cron = Fugit.parse('0 8,12,16 * * *')
puts Time.use_zone('America/New_York') { cron.next_time(Time.parse('2020-09-11 12:00:00')).to_local_time }

but it still seems to yield: 2020-09-11 20:00:00 UTC.

My version of et-orbi is .. hmm. I see two lines in the lockfile:

et-orbi (1.2.4)          
       tzinfo    
fugit (1.3.6)                                   
       et-orbi (~> 1.1, >= 1.1.8)
       raabro (~> 1.3)

I want to say 1.2.4 but I am not 100% sure.

from fugit.

jmettraux avatar jmettraux commented on June 15, 2024

@honglooker it's 1.2.4 indeed, thanks a lot!

from fugit.

honglooker avatar honglooker commented on June 15, 2024

No prob! :)

from fugit.

jmettraux avatar jmettraux commented on June 15, 2024

@honglooker

what does

uname -a
bundle exec ruby -v
bundle exec ruby -e "p ENV['TZ']"
bundle exec ruby -r et-orbi -e "EtOrbi._make_info"

yield in your environment?

(It's supposed to look like

Darwin pollux.local 17.7.0 Darwin Kernel Version 17.7.0: Thu Dec 20 21:47:19 PST
 2018;
  root:xnu-4570.71.22~1/RELEASE_X86_64 x86_64
ruby 2.3.7p456 (2018-03-28 revision 63024) [x86_64-darwin17]
(secs:1553304485.185308,utc~:"2019-03-23 01:28:05.18530797958374023",ltz~:"JST")
(etz:nil,tnz:"JST",tziv:"2.0.0",tzidv:"1.2018.9",rv:"2.3.7",rp:"x86_64-darwin17"
,win:false,
  rorv:nil,astz:nil,eov:"1.1.7",eotnz:#<TZInfo::TimezoneProxy: Asia/Tokyo>,eotnf
z:"+0900",
  eotlzn:"Asia/Tokyo",eotnfZ:"JST",debian:nil,centos:nil,osx:"zoneinfo/Asia/Toky
o")

)

Thanks in advance.

from fugit.

honglooker avatar honglooker commented on June 15, 2024

uname -a

Darwin [REDACTED] x86_64

bundle exec ruby -v

jruby 9.1.17.0 (2.3.3) 2018-04-20 d8b1ff9 Java HotSpot(TM) 64-Bit Server VM 25.221-b11 on 1.8.0_221-b11 +jit [darwin-x86_64]

Note: Looks like jruby for this utc_repro.rb instance is a version behind what I expected. Does not change outcome

bundle exec ruby -e "p ENV['TZ']"

nil

Note: nil because I manually set timezone via system settings

bundle exec ruby -r et-orbi -e "EtOrbi._make_info"

Gem::LoadError: You have already activated tzinfo 2.0.2, but your Gemfile requires tzinfo 1.2.7. Prepending `bundle exec` to your command may solve this.
  check_for_activated_spec! at [...]jruby-9.1.17.0/lib/ruby/gems/shared/gems/bundler-2.0.2/lib/bundler/runtime.rb:319
    block in setup at [...]jruby-9.1.17.0/lib/ruby/gems/shared/gems/bundler-2.0.2/lib/bundler/runtime.rb:31
      each at org/jruby/RubyArray.java:1735
      each at [...]jruby-9.1.17.0/lib/ruby/gems/shared/gems/bundler-2.0.2/lib/bundler/spec_set.rb:148
        map at org/jruby/RubyEnumerable.java:830
      setup at [...]jruby-9.1.17.0/lib/ruby/gems/shared/gems/bundler-2.0.2/lib/bundler/runtime.rb:26
      setup at [...]jruby-9.1.17.0/lib/ruby/gems/shared/gems/bundler-2.0.2/lib/bundler.rb:107
      <main> at [...]jruby-9.1.17.0/lib/ruby/gems/shared/gems/bundler-2.0.2/lib/bundler/setup.rb:10
      require at org/jruby/RubyKernel.java:956
      require at [...]jruby-9.1.17.0/lib/ruby/stdlib/rubygems/core_ext/kernel_require.rb:55

Note: interesting failure here. Surprised to see a stacktrace. Maybe because my repro gemfile does not explicitly import EtOrbi? Should be there as a dependency...

Let me know if you need anything else from me. Thanks again for taking a look!

from fugit.

honglooker avatar honglooker commented on June 15, 2024

Got it. Had to bundle clean --force:

(secs:1600196163.6663709,utc~:"2020-09-15 18:56:03.6663708686828613",ltz~:"UTC")
(etz:nil,tnz:"UTC",tziv:"1.2.7",tzidv:nil,rv:"2.3.3",rp:"java",win:false,rorv:nil,astz:nil,eov:"1.2.4",eotnz:#<TZInfo::DataTimezone: UTC>,eotnfz:"Z",eotlzn:"UTC",eotnfZ:"UTC",debian:nil,centos:nil,osx:"UTC")

Thanks again!

from fugit.

jmettraux avatar jmettraux commented on June 15, 2024

@honglooker wrote:

Note: nil because I manually set timezone via system settings

Thanks, I wanted to double check that it wasn't set on top of the system settings. EtOrbi and Fugit do follow TZ over other zone indicators.

from fugit.

honglooker avatar honglooker commented on June 15, 2024

Gotcha, thanks for clarifying.

from fugit.

jmettraux avatar jmettraux commented on June 15, 2024

I think that's the cause of the skip:
https://github.com/floraison/fugit/blob/master/lib/fugit/cron.rb#L254-L258

I'll investigate further during my next break.

from fugit.

jmettraux avatar jmettraux commented on June 15, 2024

@honglooker Hello, I think the fix above solves your issue. If you could verify on your side and let me know. Thanks in advance!

from fugit.

honglooker avatar honglooker commented on June 15, 2024

Hey, thanks for the quick fix! I gave it a try:

...
Using fugit 1.3.9 from git://github.com/floraison/fugit (at master@6792de1)
...
❯ bundle exec ruby utc_repro.rb
2020-09-11 16:00:00 UTC

I'm getting 16:00, which is 12:00 eastern time -- it works. Thank you for the fast turnaround time!

from fugit.

jmettraux avatar jmettraux commented on June 15, 2024

OK, thanks again, I'll release 1.3.9 soon and then close the issue. I'm happy you circled this one.

from fugit.

honglooker avatar honglooker commented on June 15, 2024

Great, thank you!

from fugit.

jmettraux avatar jmettraux commented on June 15, 2024

Fugit 1.3.9 is available.

Thanks a lot!

from fugit.

honglooker avatar honglooker commented on June 15, 2024

Perfect, much appreciated!

from fugit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.