Redefinition of Starscream modulemaps about livegql HOT 6 CLOSED

Interesting point... I didn't think about dependencies like that with Pod, I will update very soon the library with a fix for a manual install.

Maybe I'm gonna give up Starscream and use SocketRocket by Facebook. In all cases, one of those will be integrated in LiveGQL and won't be used a Pod reference

from livegql.

Thanks for taking this up !
I do have a question regarding this, if you could help me out.

Why does the LiveGQL framework bring in the Starscream modulemap files ? Even if I just link to the Starscream framework and not actually include it in the Build phases for the LiveGQL framework project ?

Also, if there are simple steps which you know will work, please let me know. I am willing to take the time to fix this. I want to make some changes to the code for my usage.

from livegql.

Hey, so I made the changes that you suggested.
I think the issue is with Starscream but there is no input from them yet which is problematic for me.

So I forked and created a branch with all the changes.

My setup now seems to be working so now I have a library which I can update and use in my app :)
Let me know if you want to open a pull request and integrate these changes into your code.
Also, if you find any issues with the code, do let me know so that I can improve quality.

from livegql.

Hello!

Thank for all your investment in the project and happy it works now, I saw your branch but not reviewed yet, but it would be cool if you make a PR, I will check it this week end!

Cheers!

from livegql.

Hey @rhishikeshj

I looked over your contribution and it is so cool for the future of LiveGQL i'm working on. Is it possible to make a PR into the "develop" branch? I'm gonna release a new version by the end of January

Thank you!

from livegql.

Merged and released

from livegql.