Counter forward stops at 60 seconds about simpletimeraddon HOT 5 CLOSED

The default value and the decrease logic are inherit from the original component that the add-on is based on. I would also expect that the count up never ends if no end time is defined. So how can we make the API less poor? Should we remove the default value in case on countUp or just replace the decrease logic or remove the default value completely from the component?

Any fix would be a breaking change, so let's figure out what makes most sense in this case.

IMHO either there should be no default value (some initial value is needed for count down, but there's nothing special in "60" and users will likely need to set an initial value that is different from 60), and/or there should be an endTime property that applies to count up, so that count up does not end at the so-called "startTime"

from simpletimeraddon.

The "problem" is here

Should the default value for the startTime property be set to some other default when countUp is set?

from simpletimeraddon.

As a user, I would expect that the default value of "startTime" does not affect when the count up ends, and if there is no "endTime", I would expect that the count up does never end. (It does not matter how it is implemented. Having "startTime" act as "endTime", and having that end-time be 60 just because 60 is a reasonable default for count down, is poor API and does not make sense)

from simpletimeraddon.

The default value and the decrease logic are inherit from the original component that the add-on is based on. I would also expect that the count up never ends if no end time is defined. So how can we make the API less poor? Should we remove the default value in case on countUp or just replace the decrease logic or remove the default value completely from the component?

from simpletimeraddon.

At least the demo should make sense, when enabling the count up checkbox the textfield changes to "End time", we could populate it with 60.

from simpletimeraddon.