rename back fromEd25519SK into fromSeed about js-client HOT 7 CLOSED

We a looking for a way to implement more key types in the future, so simple fromSeed would be confusing. fromEd25519SK correctly describes what the method is actually doing. Is there any specific reason why you want this to be renamed back?

from js-client.

"seed" is a confusing word, overloaded with meanings. Also, it's not used in public-key cryptography, ed25519 algorithm, or other papers, AFAIK.

"seed" usually refers to PRNG's seed. But some cryptography libraries use it incorrectly to mean "private key". This just adds to the confusion, and we want to avoid that.

from js-client.

the string passed unto subject method is not ed25.. key, from that string i can produce any key. so that is randonmess, so that is seed.

from js-client.

I understand where you coming from. I've been confused by this a lot, too.

The thing is, any byte sequence of length 32 is a valid Ed25519 key. I find that VERY surprising and amusing, but that's what it is.

And that's the reason why we've renamed the method to fromEd25519SK. fromSeed was incorrect: it's not a seed (whatever that word should mean), it's a private key.

from js-client.

but i can create key not from 32 bytea, but less or more. so i type 100 byte string and get 33 byte key.

from js-client.

any key is produced from seeds, may that was api that hides that?

from js-client.

I understand where you coming from. I've been confused by this a lot, too.

The thing is, any byte sequence of length 32 is a valid Ed25519 key. I find that VERY surprising and amusing, but that's what it is.

And that's the reason why we've renamed the method to fromEd25519SK. fromSeed was incorrect: it's not a seed (whatever that word should mean), it's a private key.

Thus, closing the issue

from js-client.