Dart processes not exiting in `flutter/engine` are hard to debug on CI about flutter HOT 10 CLOSED

We should set up a time out of the specific test (smaller than the build timeout) to allow the os info collection to run in the end.

from flutter.

Also, if this is related to an emulator crash, the test should be able to catch the crash and exit early.

from flutter.

Just to be clear my specific case was a Dart script that ran an emulator, but I don't think the emulator crashed.

from flutter.

Just to be clear my specific case was a Dart script that ran an emulator, but I don't think the emulator crashed.

from flutter.

Add default timeouts for global/build tests: https://flutter-review.googlesource.com/c/recipes/+/55162

from flutter.

@matanlurey infra changes and docs have landed, can you please help us assigning the appropriate timeouts to the emulator tests in the engine json config files?

from flutter.

@matanlurey infra changes and docs have landed, can you please help us assigning the appropriate timeouts to the emulator tests in the engine json config files?

Yup, would love to do that - my only confusion is what to do if I'm happy with the default 1h timeout?

Just close this issue as done?

from flutter.

Yes, I believe we can close this bug as done, with enough time for the build to complete we will have access to the generic logs collection and process cleanup steps. We can also collect test specific logs updating the test script to collect any additional information and save it to "FLUTTER_LOGS_DIR" https://github.com/flutter/engine/blob/main/ci/builders/README.md#tests.

The defaults for tests steps are now:

• 3 retries on failures.
• 30 mins timeout

If a test times out it will retry it automatically, if you are ok with the default 30 mins test timeout then my only recommendation would be to increase the build timeout to something that allows enough time for the logs collection step to run. In this case something like 120 mins.

With enough time for the build to complete the dart processes being killed will be available in the cleanup step:

from flutter.

Perfect! This is great, thanks all!

from flutter.

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

from flutter.