Add golden test review process to release cycle about flutter HOT 7 OPEN

From the Impeller Weekly: The next steps were to append the release name (branch?) to the test to create a new variant for each release.

from flutter.

The proposal has steeped for a few weeks and doesn't seem to have strong objection, so I'll start working on this.

from flutter.

Filed #146078 to ask for infra support since I did not get a response on Discord.

from flutter.

@gaaclarke Is this effectively closed?

from flutter.

Yes, we have a way that we can do golden test reviews, we've done a trial run to prove that it works. The only outstanding work may be for any documentation surrounding releases to get updated, if they exist. It may be worth mentioning to Chris in case he knows of anything that should be updated.

from flutter.

I hesitate to add a lot of extra things on Chris' place right now, but at the same time this is pretty important for us to land Impeller and keep the quality high. @christopherfujino or @itsjustkevin could we help update the release documentation, if any?

Quick summary for the uninitiated: https://github.com/flutter/engine/tree/main/testing/skia_gold_client#release-testing

from flutter.

Or just point us to the documentation and we can update it.

from flutter.