[Impeller] 60% regression in platform view `99th_percentile_frame_rasterizer_time_millis` about flutter HOT 6 CLOSED

This may be related to the pending sema count being too low. The thing @jonahwilliams has a patch out for. Commuting ATM but can take a look soon.

from flutter.

Here are some other benchmarks that were also negatively impacted, same sorts of thing, worst frame and 90th percentile:

https://flutter-flutter-perf.skia.org/e/?begin=1714584557&end=1714609103&keys=X2c8a2b0e7b78379b8c90932639e44938&num_commits=50&request_type=1&xbaroffset=40591

from flutter.

Here's another that measure missed vsyncs:
https://flutter-flutter-perf.skia.org/e/?keys=Xbfa02752ec0e9e7569132e83baea9ae6&selected=commit%3D40592%26name%3D%252Carch%253Dintel%252Cbranch%253Dmaster%252Cconfig%253Ddefault%252Cdevice_type%253DSM-A025V%252Cdevice_version%253Dnone%252Chost_type%253Dlinux%252Csub_result%253D90th_percentile_vsync_transitions_missed%252Ctest%253Danimated_blur_backdrop_filter_perf__timeline_summary%252C&xbaroffset=40592

from flutter.

Its worth looking at all of the frame percentiles for this benchmark

The split here is odd. it looks like the average frame finishes much faster while the worst frames get much slower due to waiting on the semaphore. We should see if this device does better with backpressure enabled, or if we need to adjust semaphore and swapchain image counts.

from flutter.

Closing as we backed out the change and the benchmark has recovered.

from flutter.

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

from flutter.